Repository navigation
ci: run the unit tests when data or config change - #706
openvoiceos-bot wants to merge 1 commit into
Conversation
The unit tests read data/, and the scripts that generate data/ read config/, so a change in either directory can break the tests. The paths filter did not list them, and a pull request that changed only data started no unit test run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
I've completed my sweep! Here's the situation. 🧹I've aggregated the results of the automated checks for this PR below. 🏷️ Release PreviewThe draft for the big day is ready for review. 📝 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
🔍 LintChecking if there's anything else we need to do. 📋 ❌ ruff: issues found in 83 file(s) — see job log 🔨 Build TestsEnsuring the code is correctly packaged and ready. 📦
❌ 3.10: Install OK, tests failed Crafting a better voice assistant, one commit at a time 🎙️ |
The unit test workflow runs when
data/**orconfig/**changes, on push and on pull request.The unit tests read
data/, and the scripts that generatedata/readconfig/. Thepaths:filter did not list either directory, so a pull request that changes only data started no unit test run. ovos-localize#705, which regeneratesdata/locale_rules.json, shows this: it has no unit test check..github/workflows/unit_tests.yml'data/**'and'config/**'added to bothpaths:listsdata/test_intents_corpus.py,test_check_path_lang.py,test_publish_hf_dataset.py,test_locale_rules.py🤖 Generated with Claude Code