[gmdfalk]

Hey,

love the software, thanks for your efforts!

I have a cable modem that is currently unsupported but very popular in Germany: FritzBox.

This PR adds a new FritzBoxCableProvider to be able to monitor it as cable modem in NetworkOptimizer.
I only have FritzBox 6690 and Firmware 8.40 to test on but I think auth and cable stats have remained largely unchanged over time.

Verification done via both unit tests and building the Docker image locally and verifying that adding and monitoring my FritzBox as cable modem works.

This change is tightly scoped to just that new provider so we don't break anything outside of it.

Full disclaimer: The code is LLM generated.

[gmdfalk]

@tvancott42 could i get a review when you have some time? let me know if anything needs adjusting!

[tvancott42]

@gmdfalk on it, but along with 6 other ONT/CM providers at the moment haha. Should have this in by next week, I'm out of town for a few days but have all of these providers queued up. Thanks for the PR

[tvancott42]

OK, preliminary review findings, here's the summary to address:

• Retarget to dev. PRs here go into dev, not main. It merges cleanly onto current dev, builds with 0 warnings, and the cable modem tests pass (yours included).
• HTTPS on port 443 has no certificate handling. Port 443 switches the scheme to https, but the handler sets no SslOptions.RemoteCertificateValidationCallback. A FRITZ!Box serves a self-signed certificate by default, so 443 will likely always fail TLS validation. The other HTTPS-capable cable modem providers (e.g. TechnicolorCgaProvider, SagemcomF3896Provider) accept the device's certificate; please match them, or drop the 443 switch.
• Full login and logout on every poll. At the default 300 s interval that is 288 sign-ins a day. Does your 6690 record each one in its event log, or send login notifications if those are enabled? If it does, please keep the SID between polls and only sign in again when data.lua rejects it.
• Add FRITZ!Box to the credential-declaration test. UniFiCableInternetTests.Provider_DeclaresItsCredentialNeeds pins every cable modem provider's Credentials and BlankUsernameMeansAdmin; add a row for FritzBoxCableProvider (Required, false).
• Settings help placement (nit). "Error totals cover DOCSIS 3.0 channels; OFDM error counts are not collected." sits under the Status Page Path field, which it does not describe. It reads better as provider help near the top of the form.
• README length (nit). The README bullet is four sentences where its neighbors are one line. Please trim it to the model and firmware; the detail can live in the PR. I'll handle the FEATURES.md wording at release time, so that edit can be dropped.

PS: what model are you using, just for my own learnings and knowledge (this was an Opus 5.5 review w/ all of my local memories/context that produced these findings)?

[gmdfalk]

OK, preliminary review findings, here's the summary to address:

* **Retarget to `dev`.** PRs here go into `dev`, not `main`. It merges cleanly onto current `dev`, builds with 0 warnings, and the cable modem tests pass (yours included).

* **HTTPS on port 443 has no certificate handling.** Port 443 switches the scheme to `https`, but the handler sets no `SslOptions.RemoteCertificateValidationCallback`. A FRITZ!Box serves a self-signed certificate by default, so 443 will likely always fail TLS validation. The other HTTPS-capable cable modem providers (e.g. `TechnicolorCgaProvider`, `SagemcomF3896Provider`) accept the device's certificate; please match them, or drop the 443 switch.

* **Full login and logout on every poll.** At the default 300 s interval that is 288 sign-ins a day. Does your 6690 record each one in its event log, or send login notifications if those are enabled? If it does, please keep the SID between polls and only sign in again when `data.lua` rejects it.

* **Add FRITZ!Box to the credential-declaration test.** `UniFiCableInternetTests.Provider_DeclaresItsCredentialNeeds` pins every cable modem provider's `Credentials` and `BlankUsernameMeansAdmin`; add a row for `FritzBoxCableProvider` (`Required`, `false`).

* **Settings help placement (nit).** "Error totals cover DOCSIS 3.0 channels; OFDM error counts are not collected." sits under the Status Page Path field, which it does not describe. It reads better as provider help near the top of the form.

* **README length (nit).** The README bullet is four sentences where its neighbors are one line. Please trim it to the model and firmware; the detail can live in the PR. I'll handle the `FEATURES.md` wording at release time, so that edit can be dropped.

PS: what model are you using, just for my own learnings and knowledge (this was an Opus 5.5 review w/ all of my local memories/context that produced these findings)?

thanks for the quick review, i'll retarget the dev branch and address these. this is just stock sol 6.1 medium without any local c# history/setup (sorry if that shows)

[tvancott42]

@gmdfalk sorry about the delay, I've been out of town at an event for my other business. I'm getting this worked in for the next patch and preview releases, thanks again!