Support Cadiro's Gambit's Perandus Arrows - #2416
Conversation
|
Pushed a fix: the config now gates itself on
With the quiver equipped the numbers are unchanged (Diamond still 903,906 Full DPS on the character in the description); without it, the character measures its normal 29.45% Critical Hit Chance again.
|
1e36822 to
c685927
Compare
"Each Arrow fired is a Crescendo, Splinter, Reversing, Diamond, Covetous, or Blunt Arrow" was unsupported, so Cadiro's Gambit measured as a plain quiver with increased Attack Speed. The Diamond Arrow alone is worth more than doubling the DPS of a bow build with average Critical Hit Chance, which made the item look far weaker than it is. The six Arrows behave too differently to average into a single number, so the quiver's line only sets a condition and a new config picks which Arrow to calculate, the same shape as the existing "Random element mode" for modifiers that choose an element. Random, the default, applies none of them and leaves the current behaviour untouched. Crescendo (Chain +6, 60% increased Damage for each Chain), Splinter (Split towards 6 targets), Reversing (Pierce all targets), Diamond (all Hits are Critical Hits, 60% increased Critical Damage Bonus), Covetous (600% increased Rarity) and Blunt (600% increased Stun Buildup) all reuse existing modifiers. The Reversing Arrow also returns to you, which PoB does not model. The config gates itself on Condition:PerandusArrows, granted by the quiver. ifFlag only decides whether the control is drawn, while ConfigTab:BuildModList applies every stored list var regardless, so without the condition a build that picked Diamond and then unequipped the quiver would keep 100% Critical Hit Chance with the control no longer visible.
c685927 to
22aa718
Compare
Related to #2415.
Description of the problem being solved:
Cadiro's Gambit has the line "Each Arrow fired is a Crescendo, Splinter, Reversing, Diamond, Covetous, or Blunt Arrow", which was unsupported, so the quiver calculated as if it only granted increased Attack Speed.
The Diamond Arrow is what makes that matter: all its Hits are Critical Hits, with 60% increased Critical Damage Bonus. On a bow character sitting at 28.88% Critical Hit Chance, that Arrow takes Total DPS from 120,714 to 297,952.
The six Arrows are rolled per Arrow and behave too differently to average into one number, so the item's line only sets a flag and a new config picks which Arrow to calculate. This follows the existing "Random element mode" config for modifiers that choose an element. The default, "Random (none applied)", applies none of them, so no existing build changes.
Each Arrow reuses modifiers that already exist:
The Reversing Arrow also returns to you, which PoB does not model.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Any bow build with this item works. The quiver used above:
Before screenshot:
After screenshot: