Parse "+#% to Maximum Quality" - #2417
Open
lucaskarsten wants to merge 1 commit into
Open
Conversation
Breach Ring and Refined Breach Ring carry "+20% to Maximum Quality" and "+25% to Maximum Quality" as their implicit, and the Breachlord's prefix grants the same line. Only the "Maximum Quality is #%" wording was handled, so those items showed the implicit as an unsupported modifier. Added alongside it, display only, matching how "Maximum Quality is #%" is treated: PoB does not track quality on rings, so there is no value to apply yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Breach RingandRefined Breach Ringcarry+20% to Maximum Qualityand+25% to Maximum Qualityas their implicit (Data/Bases/ring.lua:196,203), and theBreachlord'sessence prefix grants the same line (Data/ModItem.lua:1437).ModParseronly handled theMaximum Quality is #%wording, so those items showed their implicit as an unsupported modifier.The new entry sits next to that one and is display only, for the same reason: PoB does not track quality on rings at all, so there is no value to apply yet. This only stops the line from being reported as unsupported.
Steps taken to verify a working solution:
+20% to Maximum Qualityon an equipped ring and listed the mod lines the parser left with anextrafield: the line is reported before this change and gone after it, same build file both times.ModCache.luaregenerated withREGENERATE_MOD_CACHE=1 luajit HeadlessWrapper.lua: no diff, this wording is not cached.