Add resistance-aware Trader searches - #10171
Draft
mcagnion wants to merge 8 commits into
Draft
Conversation
mcagnion
marked this pull request as draft
August 8, 2026 16:04
mcagnion
force-pushed
the
feature/trade-element-swap-search
branch
from
August 12, 2026 22:01
3206e11 to
2399075
Compare
Separate resistance swaps from cap requirements so searches can broaden elemental candidates without overvaluing excess resistance. Validate fetched permutations against the build's actual elemental and Chaos caps while preserving the listed item for import.
Keep the listed trade item unchanged while Ctrl shows the exact variant used for ranking. Highlight swapped mod lines and clarify that Harvest rolls may change.
Evaluate fetched variants cooperatively, reuse unchanged cached results, and skip permutations only when cap state and resistance dependencies prove they cannot affect the selected result.
Replace the cspell-rejected "reranking" term without changing test behavior.
Remove an unused integration-only argument and align nearby comments with project terminology. Behavior is unchanged on the standalone feature branch.
Track fetch identity independently from UI labels and invalidate stale selections while cooperative evaluation is pending. Clear capped candidate state when pasted URL results replace a generated search.
Construct tooltip instances explicitly after the upstream class-constructor migration, including the Ctrl preview and its focused tests.
Align option, cache, and evaluation names with their actual behavior. Remove duplicated result state and descriptor fields that had no production consumer.
mcagnion
force-pushed
the
feature/trade-element-swap-search
branch
from
August 18, 2026 21:03
2399075 to
8fc3682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #9217
Description of the problem being solved
Trader currently gives resistance its full weight even after a build reaches its caps. It also treats Fire, Cold, and Lightning Resistance as fixed stats, although eligible modifiers can be changed with Harvest.
Changes
Resistance swapssearches elemental resistance as a total, then reevaluates the results using the best eligible swap.Resistance capsuses the current Elemental and Chaos Resistance caps when choosing the estimated variant for each listing. Items that still miss a cap remain visible, resistance above caps does not improve that variant, and the selected result sort remains unchanged between listings.[Swap].Swap values are estimates because the resistance roll may change. Results with incomplete or ambiguous Trade metadata are left unchanged.
Estimated swap comparison
Query options
Verification
No specific build is required; the options use the current build's resistance requirements.