Implement Match & Match Cycle Repos + Implement Match Cycle CRUD - #74
Implement Match & Match Cycle Repos + Implement Match Cycle CRUD#74rootandroo wants to merge 6 commits into
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5470d2c to
dbbd19b
Compare
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (08/10/26)2 reviewers were added to this PR based on Henry Chen's automation. |
|
Code looks good, although I wonder if the match cycle repo could use some per-field update methods like match has. Also, we planning on writing any tests for these? Not sure if there's another ticket for them |
dbbd19b to
b38d8dc
Compare
b38d8dc to
1eefc69
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
thanks for the feedback il include tests in the next PR. Will update this one with the per field methods |
7421818 to
6e2e2a1
Compare
adb4bd4 to
3df3274
Compare
3df3274 to
b63a2c8
Compare
|
One other thing is that you're building out everything together layer by layer, which makes sense with how we planned it out and with AI implementing it, but it would be easier to build it out feature by feature once we get it to a little more stable state. Like having the basics set, and then adding filtering and feedback later down, instead of including it from the start. |
b63a2c8 to
dedfb71
Compare
dedfb71 to
33ce420
Compare
66cc820 to
5294cd8
Compare
8156404 to
f007db1
Compare
7fe64eb to
fd90b93
Compare
b2bfd00 to
a722b4c
Compare
4caac08 to
edba339
Compare
a722b4c to
882772e
Compare
edba339 to
4908850
Compare
5eedf76 to
2a21363
Compare
| .matchScore( | ||
| rs.getObject("match_score", Float.class) == null | ||
| ? null | ||
| : rs.getObject("match_score", Float.class).doubleValue()) |
There was a problem hiding this comment.
The code calls rs.getObject("match_score", Float.class) twice - once for the null check and once for the conversion. This is inefficient and could cause issues with certain JDBC drivers. Store the result in a variable first.
Float scoreFloat = rs.getObject("match_score", Float.class);
.matchScore(scoreFloat == null ? null : scoreFloat.doubleValue())Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
2a21363 to
2be5a8b
Compare
2be5a8b to
1cab813
Compare
- Row mappers: Instant→OffsetDateTime.toInstant() for timestamptz columns - Row mapper: Float.class for REAL match_score (was Double.class, unsupported) - setMatchScore: Integer→Double to match model type - Remove @Builder.Default isDraft=true to prevent silent flip on update
a696f35 to
d2d7604
Compare
d2d7604 to
e3578bf
Compare
|
rootandroo
changed the title
rootandroo
changed the title
3 participants
No description provided.