Skip to content

Fix translations - #1648

Open
Zarel wants to merge 4 commits into
PokeAPI:masterfrom
Zarel:fix-translations
Open

Fix translations#1648
Zarel wants to merge 4 commits into
PokeAPI:masterfrom
Zarel:fix-translations

Conversation

@Zarel

@Zarel Zarel commented Aug 25, 2026

Copy link
Copy Markdown

Change description

Hi! Pokémon Showdown is in the process of adding support for other languages. We were originally going to use PokéAPI to source species/move/ability/item names, but PokéAPI seems to be missing a few, so we're sourcing them from https://github.com/abcboy101/poke-corpus instead.

I figured I'd contribute the translations we sourced from poke-corpus back to PokéAPI, so everyone can be up-to-date.

In addition to the missing ones, you also seem to be using a mixture of Simplified and Traditional Chinese in your Traditional Chinese translation, which I also corrected for you.

AI coding assistance disclosure

Nope, no code at all.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@Naramsim Naramsim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. If you say you've already verified most of the strings then we can merge the contribution in, after the sorting. Thanks for bringing the data here as well!

Comment thread data/v2/csv/item_names.csv Outdated
Comment thread data/v2/csv/item_names.csv
Comment thread data/v2/csv/item_names.csv Outdated
@Zarel

Zarel commented Aug 25, 2026

Copy link
Copy Markdown
Author

@Naramsim Done. Yeah, this was scripted to import directly from poke-corpus which is datamined from the games themselves.

I sorted the translations I added. Do you want me to also sort the translations I didn't add? There's some other translations out of order (similar reasons to me, probably - someone wrote a script that added missing translations to the end rather than in order). It's actually really easy for me to fix for you, if you want me to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants