Repository navigation
fix: Alumni panel: year rows cannot change year or unit, and the lead mark ignores title fixes - #1010
Conversation
…ger leaves a contradicting mark (#1006) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
review-code: FAIL @ b29d46c content:18c3ad02bb37 — chosen mark can be dropped; colliding moved rows vanish from the panel review-code: FAIL (round 1, head b29d46c)CI is green at the head: 9 of 9 checks passed, including the required Criteria
Findings
Test gapsNo test covers an explicit mark that equals the record's rank outside a department, or a collision after the record changes. DeviationsTwo entries are disclosed, and both match what the diff does: no render captures, because rendering needs Diff reading was delegated to codex. I checked both findings myself against the head. Verdict-written: 2026-11-16T23:28:54Z |
#1006) A picked mark is now stored whenever it differs from what the page shows with none chosen, so Member on an imported lead title drops the lead styling. A moved or added row that clashes with a later record row stays in the fix panel, and Save refuses instead of dropping its fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Repair round 1 at 343ba6c, answering the review-code FAIL at b29d46c.
Look first at — at 343ba6c |
|
review-code: PASS @ 343ba6c content:91d6854cdc08 — both round-1 findings repaired; all six criteria met review-code: PASS (round 2, head 343ba6c)CI at the head is settled green: 9 of 9 checks passed, including the required This round read the full diff at the head and the repair delta Criteria
FindingsNone blocking. Note: while a clash stands, every Save for that person is refused until the editor moves or undoes one row. That is loud, not silent, so it meets criterion 6. DeviationsTwo entries, both match the diff: no render captures (rendering would need a local dev run), and two existing fixtures moved to the new line shape (here also given The rendered panel change is routed to Verdict-written: 2026-11-16T23:48:41Z |
|
Owner visual check (2026-11-17): the Alumni panel's year rows were checked on this PR's preview (year, unit and mark editable). This stands in for the review-ui capture, which could not render the open panel. |
Summary
The Alumni panel's "Years on the page" rows can now change their academic year, their department or division, and their mark (Member, Lead or Head), as well as their title. This works on rows from the team record and on rows added on the page. The public Alumni page lists each row under its new year and unit and shows the chosen mark, so a title fix no longer leaves a LEAD tag that contradicts it. The team record (roles) is never written.
alumni_line_fixes(migration 0090, additive) holds the moved year, the moved unit and the mark; the title stays inalumni_role_fixes. Each part left empty shows what the record says.markcolumn onalumni_added_yearsholds the mark (an older row reads as Member).unchosenMark): the record's rank in a department, and nothing elsewhere, where the title decides. So Member picked on an imported "IT Lead" row is kept and the page shows no lead styling. Where the title decides, the panel's mark picker starts with nothing picked.Tests cover changing year, unit and mark on a record row and on an added row, the title-fix mark case, a Member mark on an imported lead title, a moved row that clashes with a later record row, undo, and the double-listing refusal (
lib/dashboard/alumni.test.ts), plus the migration (lib/seed/additive-migration.test.ts).LAW-SOURCE: manifest-prose
Fixes #1006
Deviations
fabrika ui rendercaptures of/dashboard/alumniare attached. Why: this repo's render command startsnext dev, which this lane's rules forbid, and the fix panel sits behind sign-in. Disposition: stated here; the Vercel preview, the unit tests and CI are the evidence.lib/dashboard/alumni.test.ts(a line's source, mark, group kind, and the empty list of clashing lines) and one role fix inlib/about/alumni-record.test.tsto the new line shape, and renamed the test "a record year can only be retitled" to "a fix may not name an added year as one of the record's". Why: a line now carries its source and its mark, and record years are no longer title-only, which this issue changes. Disposition: stated here; the assertions are unchanged.🤖 Generated with Claude Code