Remove the inert federal CCDF implementation - #9355
Open
hua7450 wants to merge 3 commits into
Open
Conversation
Delete the legacy New York encoding under gov/hhs/ccdf — market rates (amount.yaml), copay percentages, county clusters, and the variables that read them (ccdf_age_group, ccdf_market_rate, ccdf_county_cluster, spm_unit_ccdf_subsidy, spm_unit_total_ccdf_copay, is_ccdf_home_based) plus the orphan input stubs is_ccdf_initial_income_eligible and is_ccdf_continuous_income_eligible. All were inert on main: spm_unit_ccdf_subsidy is in no benefit aggregate, so this changes no household's result. The shared federal infrastructure (is_ccdf_asset_eligible, is_ccdf_immigration_eligible_child, meets_ccdf_activity_test, is_ccdf_age_eligible, is_enrolled_in_ccdf, child_care_subsidies, ccdf_duration_of_care) is untouched, as is the partner-visible is_ccdf_eligible chain pending the partner test update. Part of #9283 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Delete is_ccdf_eligible, is_ccdf_income_eligible, is_ccdf_reason_for_care_eligible, ccdf_income_to_smi_ratio, and ccdf_income with their tests, and reword the NY/SD prose that named them. The income_limit_smi parameter stays (MO CCS reads it), as does is_ccdf_age_eligible per the issue keep list. The partner analytics-coverage tests still reference these variables on purpose: their expected failure demonstrates the contract coverage. A dedicated follow-up commit will update the partner tests. Part of #9283 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9355 +/- ##
============================================
- Coverage 100.00% 67.24% -32.76%
============================================
Files 1 3 +2
Lines 35 58 +23
Branches 2 0 -2
============================================
+ Hits 35 39 +4
- Misses 0 19 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hua7450
marked this pull request as ready for review
August 28, 2026 14:05
Delete the two ccdf edge-case files, which existed solely to contract-test the removed chain; strip the is_ccdf_eligible output pins and is_ccdf_reason_for_care_eligible input lines from the MA signature tests; and drop the inert is_ccdf_reason_for_care_eligible inputs from the Head Start edge cases (nothing reads them, so no expected output changes). Partner was notified and approved removing both variables from their request surface. Fixes #9283 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the inert federal CCDF implementation under
gov/hhs/ccdf/. The "federal" encoding was legacy New York data (market rates, copay percentages, county clusters), and the whole subsystem contributed $0 to every household:spm_unit_ccdf_subsidyis not listed inchild_care_subsidy_programs.yamlor any benefit aggregate. New York now has a proper state implementation (#9282) that reads none of these files.Fixes #9283
Changes
Commit 1 — inert NY legacy:
ccdf_age_group,ccdf_market_rate,ccdf_county_cluster,spm_unit_ccdf_subsidy,spm_unit_total_ccdf_copay,is_ccdf_home_based, and the orphan input stubsis_ccdf_initial_income_eligible,is_ccdf_continuous_income_eligibleamount.yaml(NY market rates),copay_percent.yaml,county_cluster.yamltests/policy/baseline/gov/hhs/ccdf/Commit 2 — the eligibility chain:
is_ccdf_eligible,is_ccdf_income_eligible,is_ccdf_reason_for_care_eligible,ccdf_income_to_smi_ratio,ccdf_income, and their 5 test filesHousehold API Partners, confirming the partner contract tests guard this surfaceCommit 3 — partner test update:
edge_cases/federal/childcare/ccdf/federal.yamlandccdf/ma.yaml(existed solely to contract-test the removed chain)signatures/ma.yaml: removed 20is_ccdf_eligibleoutput pins and 20is_ccdf_reason_for_care_eligibleinput linesis_ccdf_reason_for_care_eligibleinput lines (nothing reads them; no expected outputs change)Partner impact
The API partner was informed and approved removing
is_ccdf_eligible(appears in their requests as an output) andis_ccdf_reason_for_care_eligible(as an input).Kept — genuinely shared federal infrastructure
is_ccdf_asset_eligible(38 state readers),is_ccdf_immigration_eligible_child(41),meets_ccdf_activity_test(29),is_enrolled_in_ccdf,is_ccdf_age_eligible,child_care_subsidies,ccdf_duration_of_care(Idaho ICCP), and the shared parameters (asset_limit,age_limit,income_limit_smi— read by MO CCS,child_care_subsidy_programs).Testing
gov/hhs/ccdftests, 119 NY CCAP, 151 SD CCA, and 69 Idaho ICCP tests pass🤖 Generated with Claude Code