fix(git): stop implicitly linking .claude#3562
Open
richardsolomou wants to merge 1 commit into
Open
Conversation
Keep shared Claude configuration opt-in through .worktreelink so worktrees do not mutate the main checkout's agent state. Generated-By: PostHog Code Task-Id: 20616cb3-db9d-4833-87fe-8d9bc6f276a9
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
There was a problem hiding this comment.
This review was skipped because it would exceed your organization's monthly flex usage limit. Raise the limit in billing settings or wait until the next billing period resets limits.
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Worktrees implicitly share the main checkout's writable
.claudedirectory. That leaks task-local state across worktrees and can leave an absolute local symlink staged in the generated checkout.Changes
.claudesharing opt-in through.worktreelinkwhile keepingCLAUDE.local.mdlinked automatically.**/.claude/worktrees/cannot mask a missing.claudeexclude.How did you test this?
pnpm --filter @posthog/git exec vitest run src/worktree.test.ts src/queries.test.ts(58 passed)pnpm --filter @posthog/git typecheckandpnpm --filter @posthog/git buildpnpm --filter @posthog/git test(327 passed; unrelated checkpoint conflict fixture failed)Automatic notifications
Created with PostHog Code