Skip to content

Component attribute string getter in dataset - #1704

Open
figueroa1395 wants to merge 5 commits into
mainfrom
pgm/feature/dataset-component-attribute-string-getter
Open

figueroa1395 wants to merge 5 commits into
mainfrom
pgm/feature/dataset-component-attribute-string-getter

Conversation

@figueroa1395

Copy link
Copy Markdown
Member

This PR adds additional Dataset utilities to allow string attribute and string component lookup for a generic attribute in a ConstDataset given a specific scenario.

This is to enable #1685

Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395 figueroa1395 self-assigned this Nov 17, 2026
@figueroa1395 figueroa1395 added the feature New feature or request label Nov 17, 2026
@figueroa1395 figueroa1395 changed the title Pgm/feature/dataset component attribute string getter Component attribute string getter in dataset Nov 17, 2026
@sonarqubecloud

Copy link
Copy Markdown

Idx size{};

template <typename UnderlyingType> auto as() const {
assert(size == 0 || meta_attribute->ctype == ctype_v<UnderlyingType>);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is assert enough here? maybe we need to raise an error (UnreachableHit?)

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Co-authored-by: Martijn Govers <martygovers@hotmail.com>
Signed-off-by: Martijn Govers <martygovers@hotmail.com>

@mgovers mgovers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so that if you think https://github.com/PowerGridModel/power-grid-model/pull/1704/changes#r4616153751 can be post-poned or resolved, then you can merge

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants