Skip to content

chore: Bump github.com/ccoveille/go-safecast to 2.0.1 - #17

Open
ccoVeille wants to merge 1 commit into
Project-HAMi:masterfrom
ccoVeille:go-safecast
Open

ccoVeille wants to merge 1 commit into
Project-HAMi:masterfrom
ccoVeille:go-safecast

Conversation

@ccoVeille

Copy link
Copy Markdown

Signed-off-by: ccoVeille 3875889+ccoVeille@users.noreply.github.com

Note: I'm go-safecast creator and maintainer.

The v2 has breaking changes for something you were not using.

You can read https://github.com/ccoVeille/go-safecast/releases/tag/v2.0.0 if you are interested.

Signed-off-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 28, 2026 19:57
@hami-robot
hami-robot Bot requested a review from archlitchi May 28, 2026 19:57
@hami-robot

hami-robot Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ccoVeille
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot
hami-robot Bot requested a review from DSFans2014 May 28, 2026 19:57
@hami-robot

hami-robot Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Welcome @ccoVeille! It looks like this is your first PR to Project-HAMi/mock-device-plugin 🎉

@hami-robot hami-robot Bot added the size/XS label May 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the go-safecast dependency to its v2 major version and aligns the codebase with the new Go module import path.

Changes:

  • Bump github.com/ccoveille/go-safecast from v1.8.2 to github.com/ccoveille/go-safecast/v2 v2.0.1
  • Update the Go import path to use /v2
  • Refresh go.sum entries for the new module version

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
internal/pkg/api/device/device.go Updates the go-safecast import path to the v2 module path.
go.mod Upgrades the go-safecast dependency to v2.0.1 using the Go modules major-version path.
go.sum Replaces v1 checksums with v2 checksums for go-safecast.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants