Repository navigation
JMAP adapter - #36
Merged
Merged
JMAP adapter#36
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4 tasks
Documentation build overview
13 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
The JMAP adapter,
JMAPAdapterand its async twin, on the same flow as the CalDAV one. It waits for calendaring-jmap 2.0.0, I'll pin it once that's out.Where I went a different way:
@types on their own, so filling in didn't make our own writes match.notFoundends the push as gone right away, same as a 404 on CalDAV.account_idis required, since a session can reach more than one account.Also fixed on the CalDAV side: changing a create that hadn't gone out yet could drop its UID. That change now gets the same checks as a create.
Cyrus answers a state newer than any it ever issued as if nothing changed, so after a restore from backup a client would miss changes silently. It's on the compatibility page.