Repository navigation
Tests, docs and first release - #38
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Documentation build overview
59 files changed ·
|
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12. The release itself waits for calendaring-jmap 2.0.0 on PyPI and #37.
The adapter base is public now, in
calendaring_sync.adapters.base. An adapter for a new protocol only writes how it reads changes and sends one edit, and gets the rest of a sync and the async variant from the base.Sessionmoved tocalendaring_sync.session, sincereplica.pywas getting too long.MergetakesEditFieldsfrom the adapter'sedit_fields(), otherwise a merge couldn't be fingerprinted the way the server's copy is.The docs now have a quickstart, how-tos, a page on when to use it, and one on what it guarantees. Every code block is a file in
docs/examples/that the tests run and type-check, so they can't rot. Also Python 3.15, the latest pins, and a link check in CI.From @niccokunzmann's reviews of #29 and #30, before anyone depends on the API:
TakeServerandKeepEditrenamed toKeepServerandKeepLocalRecord:new(),with_copy(),synced_to(),removed_at()LoneSurrogateError, all stillValueErrorsHis points on resolutions and outcomes applying themselves, and on stores by composition, are bigger, so I'll open issues for those.
Fixed on the way: an edit refused for its logical key stayed a conflict even after the holder was gone. It goes back to pending now, but only once we actually see the key freed, so a UID held in another calendar can't make it loop.
Where I went a different way:
/en/stable/links, the PyPI install, the PyPI icon. The links 404 until the tag.I also renamed
test_sync_integration.pytotest_caldav_integration.py, since it only had the CalDAV tests.Benchmarks against
mainare within noise, except JMAP fingerprints, about 7% slower from type-checking every event'sEditFields.