Repository navigation
192 update tests python #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat-helm-46-minio-to-s3
Are you sure you want to change the base?
Changes from all commits
edb9ac1
e63c81a
63953f3
e9008b6
24d6fda
009bc4f
705cfdd
e0b95e7
8861123
491e237
4edc510
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| import logging | ||
| import os | ||
| from collections.abc import Callable | ||
| from typing import Any, TypeAlias, cast | ||
| from typing import Any, cast | ||
|
|
||
| from hera.workflows import ( | ||
| DAG, | ||
|
|
@@ -52,8 +52,8 @@ | |
| # ruff: noqa: PLC0415 | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
| WorkflowTask: TypeAlias = Any | ||
| WorkflowScript: TypeAlias = Callable[..., WorkflowTask] | ||
| WorkflowTask = Any | ||
| WorkflowScript = Callable[..., WorkflowTask] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you try using the type keyword here? e.g.,
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes this was caught by |
||
|
|
||
| # Viz worker container image. Override via VIZ_WORKFLOW_IMAGE env var. | ||
| VIZ_WORKFLOW_IMAGE: str = os.environ.get( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - this is much clearer to me because I always have to refresh my memory on what the other two arguments are for, and why
Noneis given.