[ye-luo]

Proposed changes

Reorganize and clarify exception handling (try-catch) in qmcapp.cpp for both global scope and per-ensemble calculation scopes.

Changes

• Redundancy & Deadlock Fix in qmcapp.cpp:
  • Removed the redundant inner try-catch around command-line parsing and rank verification.
  • Wrapped qmc->parse() and qmc->execute() in a dedicated try-catch (const UniformCommunicateError& ue) that aborts on the group communicator qmcComm rather than the global controller.
  • Removed unused variable validInput.
• Contextual Error Messages:
  • In qmcComm catch handler: prepended input file name and, when running ensemble jobs, the ensemble job index (qmcComm.getGroupID()).
  • In global UniformCommunicateError catch handler: prepended "Global parallel scope: " to distinguish setup/partitioning failures from calculation failures.
  • In catch (const std::exception& e) and catch (...): removed raw std::cerr usage, incorporated e.what() directly into APP_ABORT, and prepended global rank ID (OHMMS::Controller->rank()).

What type(s) of changes does this code introduce?

• Bugfix
• New feature

Does this introduce a breaking change?

• No

What systems has this change been tested on?

laptop

Checklist

• • I have read the pull request guidance and develop docs
• • This PR is up to date with the current state of 'develop'
• • Code added or changed in the PR has been clang-formatted
• • This PR adds tests to cover any new code, or to catch a bug that is being fixed
• • Documentation has been added (if appropriate)

[ye-luo]

Test this please

[prckent]

LGTM

I would like to see us achieve full coverage of the top level qmcapp.cpp features.