docs: Use column description in skill schema example - #395
docs: Use column description in skill schema example#395Mathis Derenne (mathisdrn) wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
===========================================
+ Coverage 99.88% 100.00% +0.11%
===========================================
Files 46 46
Lines 2590 2590
===========================================
+ Hits 2587 2590 +3
+ Misses 3 0 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4d4b573 to
9c1ad98
Compare
9c1ad98 to
20471a9
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the dataframely skill documentation to discourage schema column descriptions being written as standalone comment lines, and instead uses the native description="..." argument on column definitions to reduce verbosity and improve agent output consistency.
Changes:
- Updated the
MyHouseSchemaexample to usedescription="..."on column definitions (replacing#:comment lines). - Updated schema constraint guidance text to recommend the
descriptionargument for “what” descriptions of column contents.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Persist all implicit assumptions on the data as constraints in the schema. Prefer using the `description` argument to | ||
| answer the "what" about the column contents, while comments can be used to specify details that are not strictly | ||
| schema-related or relevant only to a specific data interface. |
There was a problem hiding this comment.
The # Shared primary key component with MyHouseSchema comment in MyStreetSchema was re-added because it relate to documentation rather than reference code example for AI agents.
Motivation
Having comment lines (
#:) before column definitions in theSKILL.mdcode examples leads coding agents to produce verbose dataframe schemas that prepend comments above every column definition.Changes
MyHouseSchemainskills/SKILL.mdto use the nativedescription="..."parameter on column definitions (description="Number of rooms",description="Area of the house") instead of preceding#:comments.descriptionargument for column contents while allowing comments for context not strictly schema-related or interface-specific.