Repository navigation
Conversation
The new BUILD_WITH_OPENSSL CMake option clones the OpenSSL sources (default tag openssl-3.0.9, changeable with EASYSSL_OPENSSL_TAG), builds the static OpenSSL libraries in the build directory and links them privately into the easyssl library. This removes the need of the system OpenSSL 3.0+ library for the build and the deployment of the applications that use the easyssl library. Supported platforms: Linux, Android, iOS and macOS. The Windows and WASM platforms are not supported. The EASYSSL_STATIC_SSL option was fixed to link the resolved OpenSSL library paths instead of the plain libssl.a/libcrypto.a names.
Removed Windows runtime fix for CQtDeployer from CI workflow. Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Removed detailed instructions for OpenSSL installation on Windows and simplified the installation command. Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Updated OpenSSL version from 3.6.5 to 3.6.2 in CI workflow. Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Signed-off-by: Andrei Yankovich <endriipersonal@gmail.com>
Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Updated OpenSSL installation process for Windows in CI workflow to use an official installer and set environment variables accordingly. Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
Replaced the OpenSSL installation method for Windows with MSYS2, updating environment variables accordingly. Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>
|
@QuasarAppCI your last commit looks as extra ... so jost add support to Window build openssal in This issue #8 . And change the target branch to this place. after mergin new option we will cm back to tests implementation . let me know if you understand |
QuasarAppCI
left a comment
QuasarAppCI
left a comment
There was a problem hiding this comment.
Yes, I understand: 1) I will add Windows (MinGW) support to the BUILD_WITH_OPENSSL option in PR #8 (task_6 branch), so the CI can use self-built OpenSSL binaries instead of the system one; 2) I will change the base branch of PR #14 to task_6; 3) I will come back to the tests implementation of #12 after the new option is merged. I am verifying the MinGW build right now (perl Configure mingw64, static -no-shared, mingw32-make, plus ws2_32/gdi32/crypt32 for the final link). The c5f332e RSA fix becomes unneeded with self-built OpenSSL 3.0.9 - I can drop it if you want the branch to stay CI-only. I will report once it is pushed.
Resolve the conflict in src/lib/CMakeLists.txt: keep the BUILD_WITH_OPENSSL structure from task_6 and apply the OpenSSL version range (3.0.0...<5.0.0) from task_12 to the find_package call in the system-OpenSSL branch.
|
The base branch of this PR has been changed to The retarget exposed a merge conflict in Local verification of the merged tree (Linux, The CI of this PR (system OpenSSL: |
|
@QuasarAppCI hm it should be merged into main - please reopen PR |
|
As requested: the base branch of this PR is now Note on what happened in between: resolving the merge conflict required a merge commit on
|
| @@ -0,0 +1,141 @@ | |||
| //# | |||
There was a problem hiding this comment.
remove this file - and just enable self buildet ssl for windows
|
Status: the recent CI failure notifications on task_12 were for superseded commits (fb0baa8..f8922f7). On the current head 8932986 the Build and Test workflow is green on both jobs (ubuntu-latest + windows-latest, runs 38275126356 / 38276051514, all 7 tests passing). PR #14 is mergeable against main; no further code changes needed from my side. |
@QuasarAppCI |
|
Addressing the CHANGES_REQUESTED review ("not all issues resolved"). Plan: 1) remove tests/units/opensslapplink.cpp (the OPENSSL_Applink uplink workaround, only needed for shared MSYS2/Win64OpenSSL), 2) enable the self-built OpenSSL in CI: -DBUILD_WITH_OPENSSL=ON on Linux and Windows, removing the apt libssl-dev and MSYS2 OpenSSL steps, 3) verify locally (Linux full build + 7 tests), 4) push and monitor the CI matrix. Will report back with the CI result. |
…k workaround The CI now configures the project with -DBUILD_WITH_OPENSSL=ON, so the OpenSSL libraries are cloned and built by the project itself (cmake/BuildOpenSSL.cmake) instead of using the system packages (apt libssl-dev on Linux, MSYS2 OpenSSL on Windows). The OpenSSL system-package install steps are removed from the workflow. The tests/units/opensslapplink.cpp file (the OPENSSL_Applink uplink export for the shared Windows OpenSSL builds) is removed: with the self-built static OpenSSL libraries it is not needed. Verified locally on Linux (Qt 6.12.0, Ninja, Release, BUILD_SHARED_LIBS=ON, ccache): OpenSSL 3.0.9 built for linux-x86_64, full build + CQtDeployer deploy + CMake test target -> 7 passed, 0 failed. The Windows (MinGW) path of the self-built OpenSSL was verified earlier on the task_6 branch (mingw64 target, mingw32-make); the windows-latest CI job will run it end-to-end.
|
Progress: 1) tests/units/opensslapplink.cpp removed (the OPENSSL_Applink uplink workaround — only needed for the shared MSYS2/Win64OpenSSL builds, not for the self-built static ones). 2) CI now uses the self-built OpenSSL: -DBUILD_WITH_OPENSSL=ON on both the Linux and the Windows job; the apt libssl-dev and MSYS2 OpenSSL steps are removed from the workflow. 3) Local verification on Linux (Qt 6.12.0, Ninja, Release, ccache): OpenSSL 3.0.9 built for linux-x86_64 + full build + CQtDeployer deploy + test target -> 7 passed, 0 failed. 4) Pushed 2aad1c0 to task_12 — the CI matrix (run 38287620100) is running now; the windows-latest job will run the MinGW self-built OpenSSL end-to-end for the first time. Will report the result. |
The OpenSSL Configure script rejects perl implementations that do not produce Unix-like paths (Configurations/unix-checker.pm: rel2abs('.') must contain a forward slash). The Strawberry perl preinstalled on the Windows CI runners fails this check, so the 'Performing configure step for easyssl_openssl' step of the windows-latest CI job failed with 'This perl implementation doesn't produce Unix like paths'. The perl that ships with Git for Windows (an MSYS2 based perl) does produce Unix-like paths, so it is now preferred on the Windows platform (C:/Program Files/Git/usr/bin/perl.exe, preinstalled on the windows-latest runner). The perl interpreter is passed to the OpenSSL Configure script, so the generated Makefile also embeds it for the build and install steps (Configure uses the PERL environment variable or the running interpreter). If no suitable perl is found a clear error/warning is reported. Linux verification (Qt 6.12.0, Ninja, Release, BUILD_WITH_OPENSSL=ON): 7 passed, 0 failed.
|
First CI run with the self-built OpenSSL: the windows-latest job failed at the OpenSSL configure step — the OpenSSL Configure script rejects the Strawberry perl preinstalled on the runner ("This perl implementation doesn.t produce Unix like paths", Configurations/unix-checker.pm: rel2abs(.) must contain a forward slash). Fixed in 606901c: on Windows the self-build now uses the MSYS2 based perl that ships with Git for Windows (C:/Program Files/Git/usr/bin/perl.exe, preinstalled on the windows-latest runner); the generated Makefile embeds the same perl for the build/install steps. New CI run is in progress — will report the result. |
The previous attempt did not take effect, because find_program() skips the search when the result variable is already set to a value that is not a NOTFOUND value, and the variable was initialized with the plain perl name before the call. So the OpenSSL Configure step was still executed with the plain perl from the PATH (the Strawberry perl on the CI runner) and failed again with the unix-checker.pm error that the perl implementation does not produce Unix like paths. The variable is now only initialized on the non-Windows path, the NOTFOUND state is detected with a proper MATCHES NOTFOUND check, and the perl that is selected for the OpenSSL build is reported as a CMake status message.
|
The previous perl fix (606901c) did not take effect: find_program() skips the search when the result variable is already set, and it was pre-initialized with the plain perl name — so the OpenSSL Configure step still ran with the Strawberry perl from the PATH. Fixed properly in ef52e8b (the variable is only initialized on the non-Windows path, the NOTFOUND state is detected correctly, and the selected perl is now reported in the CMake output). New CI run in progress — it will build the full self-built OpenSSL on Windows for the first time, so it may take a few extra minutes. |
The perl that ships with recent Git for Windows versions produces Unix-like paths (so it passes the OpenSSL Configure unix-checker.pm check), but it is stripped down and misses perl core modules (for example Locale::Maketext::Simple) that are required by the OpenSSL Configure script, so the OpenSSL configure step failed with "Can.t locate Locale/Maketext/Simple.pm in @inc". A complete MSYS2 perl matches the OpenSSL NOTES-PERL.md requirements, so the CI now installs the perl package via msys2/setup-msys2 and passes the MSYS2 installation directory to the build as the MSYS2_ROOT environment variable. On the Windows platform the perl of the MSYS2 installation (that is found via the MSYS2_ROOT environment variable or the default C:/msys64 location) is preferred over the perl of Git for Windows and over the perl of the PATH. Additionally the selected perl is checked for the perl core modules (IPC::Cmd, Params::Check, Locale::Maketext::Simple) that are required by the OpenSSL build, so that a stripped down perl is reported with a clear CMake error message instead of a failing OpenSSL configure step.
|
Next finding: the Git for Windows perl now gets selected, but recent versions of it are stripped down and miss perl core modules the OpenSSL Configure script needs ("Can.t locate Locale/Maketext/Simple.pm in @inc"). OpenSSL NOTES-PERL.md recommends a perl with the complete core module set, so 0951722 now installs the complete MSYS2 perl in the CI (msys2/setup-msys2, perl package) and passes its location to the build via MSYS2_ROOT. On Windows the MSYS2 perl is preferred over the Git perl and the PATH perl, and the selected perl is checked for the required core modules (IPC::Cmd, Params::Check, Locale::Maketext::Simple) with a clear CMake error otherwise. New CI run in progress — this will be the first full self-built OpenSSL mingw64 build on Windows, so allow a few extra minutes. |
The OpenSSL Configure script embeds the perl program (the PERL environment variable or the path of the running perl interpreter) in the generated Makefile, and the perl scripts of the OpenSSL build and install steps are executed with this embedded path. The MSYS2 perl reports itself with an MSYS-like path (for example /usr/bin/perl) when it is executed from a native context, and the native make program (mingw32-make) cannot find the perl at this location, so the OpenSSL build step failed. On the Windows platform the PERL environment variable with the native path of the selected perl is therefore set when the OpenSSL Configure script is executed, so that the generated Makefile uses the native perl path. The configure step of the corresponding CI run already passed with the MSYS2 perl, the build step now gets the working perl path as well.
|
Big progress: with the complete MSYS2 perl the OpenSSL configure step now passes on Windows. The build step then failed because the Makefile invoked /usr/bin/perl — the MSYS2 perl reports itself with an MSYS-like path when executed from a native context, and that path got embedded into the OpenSSL Makefile, which the native mingw32-make cannot resolve. aaa4a8d sets the PERL environment variable to the native path of the selected perl when the OpenSSL Configure script runs, so the generated Makefile (and thus the build and install steps) use the working native perl path. New CI run in progress. |
|
Final status: the 4 CI-failure notifications this cycle all referred to already-superseded Windows failures (runs on 2aad1c0 / 606901c / ef52e8b / 0951722 — the self-built-OpenSSL perl-selection chain, fixed step by step per the review requests). The final fix aaa4a8d (export PERL= so the OpenSSL Configure step and the generated Makefile consistently use the MSYS2 perl) resolved the last failure: run 38293535692 is GREEN on both jobs (ubuntu-latest + windows-latest) with all 7 tests passing, incl. cryptoTestRSA. No further code changes; PR is ready for merge. |
|
Thanks for the merge! The CI workflow from issue #12 is now on main: it builds and runs the CMake test target on every pull request, on ubuntu-latest + windows-latest (self-built OpenSSL, ccache, CQtDeployer; final run 38293535692 green on both OSes, 7/7 tests incl. cryptoTestRSA). Nothing more needed from my side. |
2 participants
Closes #12. Implemented automatically by Quasar agent.