Compat with CustomTree mod

[TubyUwU]

Describe the bug

Hey, Great Work!
Could add compat with CustomTree mod? (https://modrinth.com/mod/customtree)

Isolated reproduction

No

Minecraft version

26.1.2

Loader used

Fabric

Loader version (Fabric/Forge/NeoForge)

0.19.2

Mod version

26.1.2.4

Minecraft environment

Single player

Configuration

{
  "trees": {
    "allowedLogs": [],
    "deniedLogs": [],
    "allowedLeaves": [],
    "allowedNonDecayLeaves": [],
    "deniedLeaves": [],
    "breakMode": "INSTANTANEOUS",
    "detectionMode": "WHOLE_TREE",
    "detectionModeBiomeOverride": {},
    "maxScanSize": 500,
    "minSize": 0,
    "maxSize": 100,
    "maxLeafDistanceFromLog": 15,
    "maxSizeAction": "ABORT",
    "breakOrder": "FURTHEST_FIRST",
    "minimumLeavesAroundRequired": 1,
    "includePersistentLeavesInRequiredCount": true,
    "treeBreaking": true,
    "leavesBreaking": true,
    "leavesBreakingForceRadius": 0,
    "allowMixedLogs": false,
    "breakNetherTreeWarts": true,
    "breakMangroveRoots": true,
    "searchAreaRadius": -1,
    "allowedAdjacentBlocks": [],
    "adjacentStopMode": "STOP_ALL",
    "spawnItemsAtBreakPoint": false,
    "trunkLootPercentage": 1.0
  },
  "tools": {
    "allowed": [],
    "denied": [],
    "durabilityMode": "NORMAL",
    "ignoreTools": false,
    "damageMultiplicand": 1.0,
    "damageRounding": "ROUND_DOWN",
    "speedMultiplicand": 0.0,
    "forceToolUsage": false
  },
  "player": {
    "allowedTags": []
  },
  "enchantment": {
    "requireEnchantment": false
  },
  "sneakMode": "SNEAK_DISABLE",
  "breakInCreative": true,
  "lootInCreative": false,
  "notificationMode": "NONE"
}

Relevant log output

[Rakambda]

Edit the configuration and add the mod's log/leaf blocks IDs.

By default falling tree takes into account what is declared as logs and leaves. If it isn't the case for a mod, the manual config is here for this.

[TubyUwU]

@Rakambda tank u for the reply!

The mod use vanilla logs and leaves:

I tried adding anyway but didnt work:

[Rakambda]

Do they have the persistent flag set to true? You can see this with the F3 menu.

If yes then it's normal. Fallingtree by default doesn't allow a tree with that kind of leaves are they are only present when placed by a player. Though you seem to have set includePersistentLeavesInRequiredCount=true already.

I'll try to look a bit more into it when I have some time.

[TubyUwU]

@Rakambda

[Rakambda]

I looked a bit into it and this mod doesn't really play well with FallingTree :

• Some leaves are only "connected" diagonally, I don't remember too well if FallingTree supports that. It may leave some parts floating in the sky.
• The leaves are all set with the tag persistent=true, which is Minecraft's mecanism to have leaves never decay (when placed by the player). FallingTree by default only speeds up that decay by fast-ticking the leaves blocks. So as they are persistent, they'll never go away unless a player breaks them.
• Trees are way larger tham vanilla's ones.

You have several ways you can improve compatibility, but it'll still be messy in most cases :

• For the diagonal connection : You can set leavesBreakingForceRadius to a value greater than 0. It'll basically force to break the leaves within a radius around the top-most log of the tree. As the radius might need to be rather large, iy may introduce quite some lag, and also might destroy leaves from other trees too.
• Persistent=true : Another thing you can do is declare the leaves into the allowedNonDecayLeaves to tell FallingTree that these leaves doesn't decay naturally and therefore need to be broken by your tool (it'll use durability). However leaves might still stay behind because of the previous point. To ease adding leaves you can add the minecraft tag directly that adds them all #minecraft:leaves.
• Size : You'' have to increase maxSize and maybe maxScanSize. Especially if editing allowedNonDecayLeaves as they'd count towards breaking.

So basically there's 2 things, the size of the trees that are larger but can be easily be changed in the config (point 3), and the fact that leaves are persistent so they don't decay. This second point doesn't play well with FallingTree as it doesn't really breaks leaves.