Use AVX2 for dense in-place XOR - #550
Open
perfloop-agent wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use AVX2 for the high-cardinality bitmap-container XOR store pass and add dense XOR coverage.
Type of Change
Changes Made
What was changed?
Why was it changed?
How was it changed?
Testing
go test ./...go test -tags=appengineGOARCH=arm64 go build .GOARCH=386 go build .test -z "$(gofmt -s -l $(find . -name '*.go' -type f))" && go tool unconvert ./...Checks: 5 passed.
Formatting
gofmt -s -las part of the formatting check above.Fuzzing
Performance Impact
The AVX2 path is used only for the high-cardinality bitmap result on supported amd64 CPUs. Other paths retain the portable store loop.
Workload:
Bitmap.Xor on 50 dense matching containersns/opWorkload:
Bitmap.Xor with 1 matching dense container on amd64 AVX2ns/opWorkload:
Bitmap.Xor with 50 matching dense containers on amd64 AVX2ns/opWorkload:
Bitmap.Xor with 256 matching dense containers on amd64 AVX2ns/opBreaking Changes
Related Issues
Additional Notes
Generated by Perfloop. Human sponsor: Tomás Senart. Measurements and checks.