[Fix] Slack failure notifications arrive late after task timeouts - #1222
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] Slack failure notifications arrive late after task timeouts#1222roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Slack failure notifications now start immediately after the terminal task state is persisted. They run concurrently with parent-task settlement callbacks instead of waiting behind those callbacks and later cleanup work.
Added regression coverage that holds post-settlement work open and verifies the Slack update is delivered before that work completes.
Why this change was made
Timeout failures could appear in the task UI before the originating Slack thread received its failure update because Slack delivery ran after several potentially slow remote operations.
Impact
Users receive timeout and failure updates in Slack promptly while existing cleanup, retry messaging, cancellation normalization, and error handling remain unchanged.