[Fix] Trash icon is hidden in dark mode environment dropdown - #1285
Draft
roomote-roomote[bot] wants to merge 3 commits into
Draft
[Fix] Trash icon is hidden in dark mode environment dropdown#1285roomote-roomote[bot] wants to merge 3 commits into
roomote-roomote[bot] wants to merge 3 commits into
Conversation
Contributor
Contributor
Author
|
Fixed the dark-mode selected-row contrast in 7767740. The trash action now explicitly overrides both the dropdown SVG color and ghost-button hover color; visual proof confirms both action glyphs are visible against the lime row. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The delete action in the homepage environment dropdown now explicitly uses black against the selected lime row, while retaining its destructive color when the action itself is hovered.
Why this change was made
The previous muted and accent foreground treatments did not reliably override the dropdown and ghost-button styling in dark mode, leaving the trash glyph low-contrast or invisible.
Impact
Admins can clearly see both environment actions when hovering a selected environment in dark mode. The change is limited to the trash icon's foreground colors; its interaction remains unchanged.
Screenshots