Skip to content

[Fix] Trash icon is hidden in dark mode environment dropdown - #1285

Draft
roomote-roomote[bot] wants to merge 3 commits into
developfrom
fix/environment-trash-icon-0bx64f23iqeuz
Draft

[Fix] Trash icon is hidden in dark mode environment dropdown#1285
roomote-roomote[bot] wants to merge 3 commits into
developfrom
fix/environment-trash-icon-0bx64f23iqeuz

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @mrubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

The delete action in the homepage environment dropdown now explicitly uses black against the selected lime row, while retaining its destructive color when the action itself is hovered.

Why this change was made

The previous muted and accent foreground treatments did not reliably override the dropdown and ghost-button styling in dark mode, leaving the trash glyph low-contrast or invisible.

Impact

Admins can clearly see both environment actions when hovering a selected environment in dark mode. The change is limited to the trash icon's foreground colors; its interaction remains unchanged.

Screenshots

Dark-mode selected environment row showing visible black settings and trash icons

@roomote-community

roomote-community Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

No new code issues found. See task

  • apps/web/src/components/tasks/SelectEnvironmentOrRepository.tsx:431 uses the same accent token as the selected row background, so the trash icon remains low-contrast in dark mode.

Reviewed 7767740

Comment thread apps/web/src/components/tasks/SelectEnvironmentOrRepository.tsx Outdated
@roomote-roomote

roomote-roomote Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the dark-mode selected-row contrast in 7767740. The trash action now explicitly overrides both the dropdown SVG color and ghost-button hover color; visual proof confirms both action glyphs are visible against the lime row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant