Skip to content

[Chore] Resolve nanoid security alert - #1311

Draft
roomote-roomote[bot] wants to merge 2 commits into
developfrom
fix/dependabot-image-nanoid-2skng66q9ac8w
Draft

[Chore] Resolve nanoid security alert#1311
roomote-roomote[bot] wants to merge 2 commits into
developfrom
fix/dependabot-image-nanoid-2skng66q9ac8w

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @mrubens. View the task or mention @roomote for follow-up asks.

What changed

  • Resolve transitive nanoid versions below 4 to the existing 5.1.16 release.
  • Remove the obsolete nanoid 3.3.17 entries from the lockfile.

Why this change was made

Dependabot alert #98 covers an infinite-loop condition in older nanoid releases. The separate image-size remediation was removed from this pull request after review.

Impact

There is no intended product behavior change. The dependency graph now resolves PostCSS's older nanoid requirement to 5.1.16, while Storybook and image-size remain unchanged from develop.

@roomote-community

roomote-community Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 8d6dbf4

@mrubens

mrubens commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@roomote is it really worth breaking this if it's not being used? Is it not going to be fixed?

@roomote-community

Copy link
Copy Markdown
Contributor

I'm on it. I started a dedicated PR follow-up task for this request, and I'll keep updates here. See task

@roomote-community

Copy link
Copy Markdown
Contributor

You’re right to question it. This does not break a current Roomote path: I rechecked apps/web and there are no static image imports for Storybook to process. But it does deliberately turn that currently-unused capability into a future build failure, so this is containment rather than a real fix.

There is still no patched image-size release (2.0.2 remains latest, and both advisories list no fixed version). The stub also will not remove itself, and this PR does not currently add tracking for that cleanup. Given that the affected path is build-time and processes repository-owned images, the practical exposure is low. I would either keep the dependency and document/accept that risk for now, or keep the stub only with an explicit follow-up to remove it as soon as upstream patches it; we should not present the stub as permanently fixing the capability.

@mrubens

mrubens commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@roomote can you remove the parts of this related to image-size then?

@roomote-community

Copy link
Copy Markdown
Contributor

I'm on it. I started a dedicated PR follow-up task for this request, and I'll keep updates here. See task

@roomote-community

roomote-community Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Removed all image-size and Storybook-related changes from this PR; the final diff now contains only the nanoid remediation. Validation and pre-push checks passed in commit 8d6dbf44. See task · Revert

@roomote-community roomote-community Bot changed the title [Chore] Resolve nanoid and image-size security alerts [Chore] Resolve nanoid security alert Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants