Skip to content

[Improve] Offer communications after source control in email setup - #1331

Merged
brunobergher merged 1 commit into
developfrom
feature/reorder-email-setup-2jbsh6i8hgh9m
Aug 15, 2026
Merged

[Improve] Offer communications after source control in email setup#1331
brunobergher merged 1 commit into
developfrom
feature/reorder-email-setup-2jbsh6i8hgh9m

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

Email/password setup now presents inference configuration first, source control second, and communications third. Setup navigation, deep-link gating, and back/forward traversal all use that path-specific order.

Slack and Microsoft Teams authentication keep the existing communication-first setup sequence. Focused flow coverage verifies both branches.

Why this change was made

Users who authenticate with email and password should connect source control before choosing an optional communication provider, while provider-based authentication must continue to complete its communication setup at authentication time.

Impact

The email/password onboarding sequence is now inference, source control, communications, automation recommendations, environment creation, and invoke. Existing Slack and Teams authentication behavior is unchanged.

@roomote-community

roomote-community Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

1 issue outstanding. See task

  • apps/web/src/app/(onboarding)/setup/hooks.ts:75 Deep-linking into communications before prerequisites can skip inference and source-control setup.

Reviewed 5cf4a4c

'source-control-provider',
'source-control-config',
'source-control-connect',
'auth-provider',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auth-provider remains a deep-link-revisitable step, so an email/password user can open /setup?step=auth-provider before completing the new inference and source-control steps. If they choose “Do this later” (or complete Telegram/Discord), goToNextStep() starts after this entry in the email sequence and lands on automation recommendations, bypassing both required earlier steps. Gate this deep link until those prerequisites are complete, or only allow it as a recovery link once a communications provider is selected.

@brunobergher
brunobergher marked this pull request as ready for review August 15, 2026 10:03
@brunobergher
brunobergher merged commit faad6b7 into develop Aug 15, 2026
18 checks passed
@brunobergher
brunobergher deleted the feature/reorder-email-setup-2jbsh6i8hgh9m branch August 15, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants