[Improve] Offer communications after source control in email setup - #1331
Merged
Merged
Conversation
Contributor
| 'source-control-provider', | ||
| 'source-control-config', | ||
| 'source-control-connect', | ||
| 'auth-provider', |
Contributor
There was a problem hiding this comment.
auth-provider remains a deep-link-revisitable step, so an email/password user can open /setup?step=auth-provider before completing the new inference and source-control steps. If they choose “Do this later” (or complete Telegram/Discord), goToNextStep() starts after this entry in the email sequence and lands on automation recommendations, bypassing both required earlier steps. Gate this deep link until those prerequisites are complete, or only allow it as a recovery link once a communications provider is selected.
brunobergher
marked this pull request as ready for review
August 15, 2026 10:03
brunobergher
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 15, 2026 10:03
brunobergher
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Email/password setup now presents inference configuration first, source control second, and communications third. Setup navigation, deep-link gating, and back/forward traversal all use that path-specific order.
Slack and Microsoft Teams authentication keep the existing communication-first setup sequence. Focused flow coverage verifies both branches.
Why this change was made
Users who authenticate with email and password should connect source control before choosing an optional communication provider, while provider-based authentication must continue to complete its communication setup at authentication time.
Impact
The email/password onboarding sequence is now inference, source control, communications, automation recommendations, environment creation, and invoke. Existing Slack and Teams authentication behavior is unchanged.