[Improve] Offer communications after source control for email setup - #1332
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Improve] Offer communications after source control for email setup#1332roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| const [pendingModelProvider, setPendingModelProvider] = | ||
| useState<SetupModelProviderId | null>(null); | ||
| const [communicationAfterSourceControl] = useState( | ||
| consumeSetupEmailPasswordAuthSelection, |
Contributor
There was a problem hiding this comment.
Consuming this flag on the first signed-in mount means it is gone after any full-page setup redirect. Source-control setup deliberately redirects to OAuth and returns to /setup?step=source-control-connect; on that return the default communications-first sequence is selected, so the deep link is clamped to the still-pending communication chooser. Preserve the email-flow ordering for the signed-in setup session (or through the source-control redirect) so email users can complete source-control setup before communications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Email/password users should establish the core inference and repository connections before choosing where Roomote communicates, without changing the combined authentication and communications setup offered by Slack or Teams.
Impact
New email/password setup sessions now follow Welcome, Auth, Inference, Source Control, Comms, Automation Recommendations, Environment Creation, and Invoke. Existing Slack and Teams authentication flows retain their current ordering. Browser proof could not be captured because the seeded local account had already completed setup and no unconfigured account state was available through the normal product flow.