Skip to content

bug fix in SV propagator - #1881

Merged
danielpeter merged 1 commit into
SPECFEM:develfrom
lsawade:incident-sv-injection-fix
Oct 6, 2026
Merged

danielpeter merged 1 commit into
SPECFEM:develfrom
lsawade:incident-sv-injection-fix

Conversation

@lsawade

@lsawade lsawade commented Oct 6, 2026

Copy link
Copy Markdown

Can you verify @nqdu ?

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 39.94%. Comparing base (cc2e9ff) to head (61c08f2).

Files with missing lines Patch % Lines
src/specfem3D/couple_with_injection.f90 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1881   +/-   ##
=======================================
  Coverage   39.94%   39.94%           
=======================================
  Files         278      278           
  Lines       67577    67577           
  Branches    10708    10708           
=======================================
  Hits        26996    26996           
  Misses      40567    40567           
  Partials       14       14           
Flag Coverage Δ
coverage-testname- 39.94% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nqdu

nqdu commented Oct 6, 2026

Copy link
Copy Markdown
image @lsawade your modification looks correct.

@lsawade

lsawade commented Oct 6, 2026

Copy link
Copy Markdown
Author

Thanks @nqdu !

@danielpeter
danielpeter merged commit 1d9fcd2 into SPECFEM:devel Oct 6, 2026
56 of 57 checks passed
@danielpeter

Copy link
Copy Markdown
Member

thanks 🙏 Nanqiao for reviewing!

@lsawade
lsawade deleted the incident-sv-injection-fix branch October 6, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants