Skip to content

Fix install.sh script #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthieu526-scalingo merged 2 commits into from
Feb 10, 2026
Merged

Fix install.sh script #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd3a031
Fix install.sh script
matthieu526-scalingo Feb 9, 2026
3957eb5
Update CHANGELOG.md
matthieu526-scalingo Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## To Be Released

* fix(dist): improve version detection in `install.sh`

## 1.43.0

* feat(databases next generation): add database plan upgrade command
Expand Down
4 changes: 2 additions & 2 deletions dists/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ main() {
if [ -x "$target" ] && [ -z "$yes_to_overwrite" ] ; then
export DISABLE_UPDATE_CHECKER=true
# Use cut's short parameter to be compatible with MacOS: https://ss64.com/osx/cut.html
new_version=$($exe_path --version | cut -d' ' -f4)
old_version=$("$target" --version | cut -d' ' -f4)
new_version=$($exe_path --version | cut -d' ' -f3)
old_version=$("$target" --version | cut -d' ' -f3)
Comment on lines +181 to +182

Copilot AI Feb 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cut -d' ' -f3 is still quite brittle because it assumes the version will always be the 3rd whitespace-delimited token. Since --version output formatting can change (extra words, different binary name, etc.), consider extracting the last token instead (e.g., via awk '{print $NF}') or a simple semver regex, to make version detection more robust.

Copilot uses AI. Check for mistakes.
warn "Scalingo client is already installed (version ${old_version})\n"

if ! ask "Do you want to replace it with version ${new_version}?" ; then
Expand Down