Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject request-body framing on CONNECT before switching to tunnel mode.
Milo previously entered the tunnel as soon as it recognized CONNECT, so bytes declared as a request body by
Content-LengthorTransfer-Encodingwere instead exposed as tunnel data. Intermediaries that honored the framing could disagree about the message boundary.CONNECT requests now reject either framing header, including
Content-Length: 0. Unframed CONNECT requests retain their existing tunnel behavior, and the request-only guard preserves externally marked CONNECT response handling.Rust, mirrored WASM, and fuzz conformance regressions cover both framing forms and the positive unframed tunnel path. The full Rust/fuzz and 100-test WASM suites pass, including focused non-SIMD validation.
This fixes SEC-12 from #38.