Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject parse ranges that cannot be represented by Milo's event format.
Event offsets and lengths are encoded as unsigned 32-bit values. Native callers could previously pass a range larger than 4 GiB and receive silently wrapped callback coordinates.
On 64-bit native targets, Milo now rejects either a current input or a managed retained/current aggregate above
u32::MAXwith the appendedERROR_INPUT_TOO_LARGEcode before accessing the unrepresentable data. Error callbacks retain normalparse()delivery. Event writers use checked conversions, so no coordinate is silently narrowed.A native regression uses inaccessible synthetic ranges to prove both rejection paths run before pointer access and verifies one
on_errorcallback per call. Documentation records the native limit and WebAssembly's naturally 32-bit coordinates.The full Rust/fuzz, C++ reference, and 98-test WASM suites pass; Rust references and independent review also pass.
This fixes SEC-14 from #38.