Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in first-party semantic validation layer for proxy/server request routing.
strict_proxy_semanticsremains disabled by default, preserving Milo's lower-level compatibility. When enabled for requests, Milo now:Hostfield;Hostin trailers;OPTIONSwhile preserving the dedicatedPRI * HTTP/2.0path;CONNECT;Hostcase-insensitively, including explicit ports, without default-port inference.The option defaults false and does not affect response parsing. It is exposed through Rust, native C, and generated WASM APIs. Parser-owned target-authority storage is cleared between messages, on reset, and on destruction.
Mirrored Rust/WASM regressions cover opt-in compatibility, all valid target forms, valid and malformed percent encoding, URI component grammar, missing/empty/duplicate/invalid Host, authority mismatch, CONNECT port requirements, and Host trailers. Documentation now distinguishes the default syntax-only boundary from strict routing validation.
Validation: full Rust suite, rebuilt 101-test SIMD WASM suite, no-SIMD compliance suite, and C++ reference suite pass. Independent review found no SEC-22 blockers.
Merge-order note: this should land after #54, which independently fixes SEC-07 atomic semantic-header event delivery.
This fixes SEC-22 from #38.