Repository navigation
Conversation
Ji-One1
force-pushed
the
jb-checkout-testids
branch
from
October 21, 2026 21:17
e975207 to
9e00031
Compare
Ji-One1
force-pushed
the
jb-checkout-testids
branch
from
October 21, 2026 21:52
9e00031 to
7640321
Compare
Ji-One1
force-pushed
the
jb-checkout-testids
branch
2 times, most recently
from
October 22, 2026 07:32
31c426d to
c7c00a2
Compare
Ji-One1
force-pushed
the
jb-checkout-testids
branch
from
October 22, 2026 08:12
c7c00a2 to
6f11d29
Compare
Ji-One1
marked this pull request as ready for review
October 22, 2026 08:30
Ji-One1
force-pushed
the
jb-checkout-testids
branch
from
October 22, 2026 15:52
6f11d29 to
1f046d4
Compare
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
fredericoo
reviewed
Oct 22, 2026
Ji-One1
force-pushed
the
jb-checkout-testids
branch
from
October 23, 2026 06:05
571cfdf to
b352f5f
Compare
Ji-One1
force-pushed
the
jb-checkout-testids
branch
2 times, most recently
from
October 23, 2026 21:02
26f749c to
ce10e58
Compare
A cart line or checkout link inside a hidden cart page or drawer is hidden too, so its own visible filter already excludes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ji-One1
force-pushed
the
jb-checkout-testids
branch
from
October 23, 2026 22:07
ce10e58 to
68c1e53
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkout journey needs to find the populated cart and activate its checkout link without depending on English button text or unrelated links elsewhere on the page.
PR 3 of the test-ID migration, based on #4218 (
jb-cart-testids).What this changes
cart-drawer,cart-page, andcart-linein the existing checkout setup.cart-checkoutto the existing checkout links in the three storefronts.Developer impact
Adds placement guidance to the repo-level
skills/hydrogen-storefront-testing/SKILL.mdso an agent can prepare a custom storefront for the portable suite. Custom storefronts needcart-checkouton their cart page checkout link for the checkout test to pass. The existing UI structure, styles, accessibility, and interactions stay unchanged.No package changeset is needed: these changes affect the repo-level tests, guidance, and reference storefront markup.
Verification
Local verification of the rebased five-PR stack at
2e41aa686, against freshly built React Router, Next.js, and Nuxt storefronts using live tokenless mock.shop. Headless Playwright, two workers, no retries or flaky results.The suite contains its 15 existing tests, including two variant helper checks. This is a full-stack run, not a separate live run of each intermediate PR.
Since that run, the container locators (
cart-page,cart-drawer,product-results) no longer narrow the container with their own visibility filter. The nested element's visibility check already excludes anything inside a hidden container. The live suite has not been rerun since that change; E2E typecheck and lint pass at55a466745.All three app builds passed. E2E typecheck and lint passed. These are local results; GitHub Actions reports separately.
Skips: no suitable live narrowing-filter or price-range fixtures on all three storefronts; Next.js retains its no-JavaScript variant opt-out. Those journeys remain unverified in this run.
How to Test
pnpm install --frozen-lockfileandpnpm run build:pkgs. Without private store credentials, the examples use mock.shop.pnpm --filter @shopify/hydrogen-template-react-router build && pnpm --filter @shopify/hydrogen-template-react-router exec vite preview --port 4311pnpm --filter @shopify/hydrogen-example-nextjs build && pnpm --filter @shopify/hydrogen-example-nextjs start --port 4312pnpm --filter @shopify/hydrogen-example-nuxt build && PORT=4313 pnpm --filter @shopify/hydrogen-example-nuxt start/cart, and activate the checkout link. Confirm checkout navigation starts. Do not enter payment details or place an order.