Repository navigation
Conversation
Ji-One1
force-pushed
the
jb-search-testids
branch
from
October 21, 2026 21:17
4304f50 to
04ae7f0
Compare
Ji-One1
force-pushed
the
jb-search-testids
branch
2 times, most recently
from
October 22, 2026 07:00
b056d55 to
3c37045
Compare
Ji-One1
force-pushed
the
jb-search-testids
branch
2 times, most recently
from
October 22, 2026 08:12
e9dc3d2 to
8c99b89
Compare
Ji-One1
force-pushed
the
jb-search-testids
branch
from
October 22, 2026 15:52
8c99b89 to
eb1bbb1
Compare
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Ji-One1
marked this pull request as ready for review
October 22, 2026 16:27
Ji-One1
force-pushed
the
jb-search-testids
branch
from
October 23, 2026 06:05
753255e to
da59654
Compare
Ji-One1
force-pushed
the
jb-search-testids
branch
from
October 23, 2026 18:18
da59654 to
4047113
Compare
Ji-One1
force-pushed
the
jb-search-testids
branch
from
October 23, 2026 21:02
4047113 to
2e41aa6
Compare
A product card inside a hidden product-results is hidden too, and the role match and per-link visibility check already exclude it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ji-One1
force-pushed
the
jb-search-testids
branch
from
October 23, 2026 22:07
2e41aa6 to
55a4667
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A storefront can have header search, predictive search, and a full search page. Dedicated search-page test IDs let the portable journey operate the intended form and read its product results.
PR 5 of the test-ID migration, based on #4235 (
jb-collection-testids).What this changes
search-inputto the existing full search-page input in all three storefronts.search-submitto the existing Next.js and Nuxt submit controls. React Router uses Enter.product-resultsandproduct-card.Developer impact
Adds placement guidance to the repo-level
skills/hydrogen-storefront-testing/SKILL.mdso an agent can prepare a custom storefront for the portable suite. The existing UI structure, styles, accessibility, and interactions stay unchanged.No package changeset is needed: these changes affect the repo-level tests, guidance, and reference storefront markup.
Verification
Local verification of the five-PR stack at
8c99b89e219e401abcc89d40a810dda86d36f340, against freshly built React Router, Next.js, and Nuxt storefronts using live tokenless mock.shop. Headless Playwright, two workers, no retries or flaky results.The suite contains its 15 existing tests, including two variant helper checks. This is a full-stack run, not a separate live run of each intermediate PR.
All three app builds and TypeScript checks passed, including React Router GraphQL checks. Formatting, lint, E2E typecheck, and seven E2E unit tests passed. These are local results; GitHub Actions reports separately.
Skips: no suitable live stock-limit, narrowing-filter, or price-range fixtures on all three storefronts; Next.js retains its no-JavaScript variant opt-out. Those journeys remain unverified in this run.
How to Test
pnpm install --frozen-lockfileandpnpm run build:pkgs. Without private store credentials, the examples use mock.shop.pnpm --filter @shopify/hydrogen-template-react-router build && pnpm --filter @shopify/hydrogen-template-react-router exec vite preview --port 4311pnpm --filter @shopify/hydrogen-example-nextjs build && pnpm --filter @shopify/hydrogen-example-nextjs start --port 4312pnpm --filter @shopify/hydrogen-example-nuxt build && PORT=4313 pnpm --filter @shopify/hydrogen-example-nuxt start/search, search for a product title from the catalog, and confirm its product result appears. Use the existing submit button in Next.js/Nuxt and Enter in React Router.