Repository navigation
Conversation
The module-private symbol is never read and cannot be named by consumers. Remove its declaration, both handler type members, and property write to finish the cleanup started in #3932. Keep TCartQuery because CartDataFromQuery<TCartQuery> still determines the default cart type. Co-authored-by: AI (Pi/Claude Opus 5.5) <noreply@pi.dev>
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused, module-private cart query metadata from cart server handlers, completing the cleanup started in #3932, which stopped exporting the symbol after finding no consumers.
Before
After
TCartQueryremains in both handler types because it still determines the defaultTCartthroughCartDataFromQuery<TCartQuery>.What this changes
cartBuyerIdentitySyncbrand unchanged.Developer impact
No changeset is included: this has no runtime behavior change, and consumers could not name the non-exported symbol.
Out of scope
Generated docs data is not updated here; the stale entries will be removed on the next docs regeneration.
Risk
Type-only:
keyof CartServerHandlersno longer includes the private symbol, and a hand-built object can now satisfyCartServerHandlers(the unnamed symbol member previously made that impossible). No Hydrogen API takesCartServerHandlersas an input type, andCartServerHandlersWithCustomerSessionretains the separately usedcartBuyerIdentitySyncbrand checked at runtime.