Repository navigation
Add JSONL output to hydrogen dev - #4273
Open
gonzaloriestra wants to merge 4 commits into
Open
gonzaloriestra wants to merge 4 commits into
gonzaloriestra wants to merge 4 commits into
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 27, 2026 12:42
5c882a2 to
a70dc84
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
2 times, most recently
from
October 27, 2026 13:07
e98e816 to
25bc0a5
Compare
gonzaloriestra
marked this pull request as ready for review
October 27, 2026 13:32
This comment has been minimized.
This comment has been minimized.
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 27, 2026 14:04
25bc0a5 to
d30eda3
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 27, 2026 14:37
d30eda3 to
adf05a7
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
2 times, most recently
from
October 27, 2026 14:54
adf05a7 to
ceb6bac
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 27, 2026 15:15
ceb6bac to
99d65b9
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 27, 2026 15:46
99d65b9 to
a05dc8c
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 27, 2026 16:15
a05dc8c to
8c85ce1
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 27, 2026 16:40
8c85ce1 to
20d9c6e
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 27, 2026 17:03
20d9c6e to
a87fe0e
Compare
fredericoo
requested changes
Oct 27, 2026
fredericoo
left a comment
Contributor
There was a problem hiding this comment.
thank uuu
left a few blocking comments, pls resolve when u can
5 tasks done
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 28, 2026 10:18
a87fe0e to
e86a93c
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 28, 2026 10:23
e86a93c to
03a4057
Compare
fredericoo
approved these changes
Oct 28, 2026
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 28, 2026 15:06
9e7af72 to
8111c95
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
3 times, most recently
from
October 28, 2026 16:17
5c46a9a to
d8d378c
Compare
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-json
branch
from
October 28, 2026 16:38
d8d378c to
6bbd062
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/24321.
Agents need structured live output from
hydrogen dev. This builds on the Dev Instance layer, following Shopify/cli#8996.WHAT is this pull request doing?
Add
--json(-j,SHOPIFY_FLAG_JSON) to stream the same JSONL bytes to stdout and the session log. Reuse CLI Kit's typed log schema for readiness, runtime messages, requests, file changes, codegen output, recoverable errors, and shutdown. CLI diagnostics use stderr; fatal errors use the standard JSON error envelope on stdout. There is no final success result.Run codegen watchers from the storefront directory so relative schema and document paths work with
--path, while preserving explicit config paths.Keep
--no-inputindependent. Disable terminal shortcuts and banners in JSON mode, keep existing noise filters without debouncing repeated worker messages, capture console methods includingdirandtable, and expose schemas through--json-schema. Update command help and the manifest, and remove dev's typed JSON lint exception.Declare the command schema as a static field. Patch the pinned CLI ESLint rule to accept initialized schema fields, matching the rule in Shopify/cli.
How to manually test your changes?
pnpm shopify hydrogen dev --path /path/to/project --json --no-input > /tmp/hydrogen-dev.jsonlwith existing authentication and configuration.console.logorconsole.table, and trigger a recoverable worker error. Confirm messages reach the stream while the session continues./tmp/hydrogen-dev.jsonlwith the session's retainedlogFile; their bytes should match.pnpm shopify hydrogen dev --json-schemato inspect the record, error, event, and runtime-details schemas.Checklist