Skip to content

Align the PR template with the pull-request-standards skill - #4277

Closed
fredericoo wants to merge 1 commit into
mainfrom
fb-pr-template-style
Closed

fredericoo wants to merge 1 commit into
mainfrom
fb-pr-template-style

Conversation

@fredericoo

Copy link
Copy Markdown
Contributor

TL;DR: The PR template and the repo's pull-request-standards skill describe two different shapes for a PR description. Agents follow the skill and humans follow the template, so descriptions are inconsistent. This makes the template match the skill, so there is one source of truth.

Before

WHY / WHAT / HOW to test headings, a post-merge section, and a five-item contributor checklist.

After

The skill's structure: a closing issue line and a TL;DR, followed by optional Before, After, What this changes, Developer impact, UX impact, Out of scope, Risk, and How to Test sections. Each section has a short comment that says when to use it and when to delete it.

What this changes

  • Rewrites .github/PULL_REQUEST_TEMPLATE.md to follow skills/pull-request-standards.
  • Moves the changeset guidance (patch / minor / major) into Developer impact, matching the skill's versioning rules.
  • Moves the cross-platform reminder into Risk.
  • Keeps the gif accessibility guidance (under UX impact) and Post-merge steps with the includes-post-merge-steps label. The skill doesn't cover either, but both are existing repo conventions.
  • Removes the checklist. Its items are now covered by section prompts. Tests no longer have a checkbox, because the skill keeps automated tests out of PR descriptions.

Risk

  • Without the checklist, nothing explicitly prompts for a link to the contributing guidelines or for added tests. If reviewers rely on those checkboxes, we can add them back as a short checklist.

@shopify

shopify Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Oxygen deployed a preview of your fb-pr-template-style branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment October 27, 2026 3:15 PM

Learn more about Hydrogen's GitHub integration.

@fredericoo
fredericoo marked this pull request as ready for review October 27, 2026 15:22
@fredericoo
fredericoo requested a review from a team as a code owner October 27, 2026 15:22
@fredericoo

Copy link
Copy Markdown
Contributor Author

superceded by #4210

@fredericoo fredericoo closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant