Repository navigation
Align the PR template with the pull-request-standards skill - #4277
Closed
fredericoo wants to merge 1 commit into
Closed
fredericoo wants to merge 1 commit into
fredericoo wants to merge 1 commit into
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
fredericoo
marked this pull request as ready for review
October 27, 2026 15:22
Contributor
Author
|
superceded by #4210 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: The PR template and the repo's
pull-request-standardsskill describe two different shapes for a PR description. Agents follow the skill and humans follow the template, so descriptions are inconsistent. This makes the template match the skill, so there is one source of truth.Before
WHY/WHAT/HOW to testheadings, a post-merge section, and a five-item contributor checklist.After
The skill's structure: a closing issue line and a TL;DR, followed by optional
Before,After,What this changes,Developer impact,UX impact,Out of scope,Risk, andHow to Testsections. Each section has a short comment that says when to use it and when to delete it.What this changes
.github/PULL_REQUEST_TEMPLATE.mdto followskills/pull-request-standards.Developer impact, matching the skill's versioning rules.Risk.UX impact) andPost-merge stepswith theincludes-post-merge-stepslabel. The skill doesn't cover either, but both are existing repo conventions.Risk