Document fieldref combinations and remove the duplicate neq entry - #222
Merged
Merged
Conversation
Member
|
The changes should target the v2.2 branch. I already changed it for you, please resolve the conflcits. |
fieldref rejects wildcards and may be followed by contains, startswith, or endswith. neq stays the generic negation modifier, so the numeric section no longer repeats it.
mostafa
force-pushed
the
fix/fieldref-modifiers
branch
from
September 25, 2026 20:41
7997919 to
8a74bac
Compare
nasbench
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This records behavior pySigma already implements.
fieldrefrejects a referenced name that contains wildcards (SigmaFieldReferenceModifierraises "Field references must not contain wildcards").fieldrefmay be followed bycontains,startswith, orendswith. Those modifiers set the field reference'sstarts_withandends_withflags (containssets both). A string modifier written first inserts wildcards, which the field reference then rejects, so the string modifier has to come afterfieldref.fieldrefmay be combined withneq. In pySigma,neqisSigmaNegateModifier, which negates the detection item. It is not the numericSigmaNotEqualModifier.neqa second time. That entry is removed. The genericneqentry stays.Test plan
mdformat --check specification/sigma-appendix-modifiers.md