Add integration_test case: scroll clips overflowing content - #152
Open
beaucollins wants to merge 1 commit into
Open
Add integration_test case: scroll clips overflowing content#152beaucollins wants to merge 1 commit into
beaucollins wants to merge 1 commit into
Conversation
A <scroll> with a fixed height must clip and scroll content taller than its bounds. Under the new web renderer the scroll box grows to its content height (600px here instead of 200px), so it does not clip and pushes following siblings off-canvas. This case renders a fixed-height scroll over tall content plus a sentinel below it; the web-vs-native snapshot diff catches the missing clip. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📊 PR Size: size/STotal changes: 25 lines (1 files) Top files changed:
Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
apps/integration_testcase that documents a web-renderer regression on this branch (#148): a<scroll>with a fixed height renders at its content height instead of clipping/scrolling, so it overflows its bounds and pushes following siblings off-canvas.Root cause
src/valdi_modules/src/valdi/web_renderer/src/elements/ScrollElementClass.ts— the scroll box's own height +overflowaren't applied to constrain it, so it grows to content.Repro
Case
scroll-overflow-clippingrenders aheight=200scroll over 600px of content plus a sentinel below it. Web: the scroll box renders ~600px and the sentinel is shoved down/off. Native: the scroll is 200px and content scrolls within it. The web-vs-native diff fails.Suggested fix
Apply the scroll element's own height +
overflowso content is clipped/scrollable within the box.