Add GatherToZarr and save pipeline node extension data to disk - #4703
Open
alejoe91 wants to merge 30 commits into
Open
Add GatherToZarr and save pipeline node extension data to disk#4703alejoe91 wants to merge 30 commits into
GatherToZarr and save pipeline node extension data to disk#4703alejoe91 wants to merge 30 commits into
Conversation
…into lazy-extensions
…into lazy-extensions
alejoe91
marked this pull request as ready for review
July 23, 2026 12:31
This was referenced Jul 28, 2026
alejoe91
commented
Sep 4, 2026
|
|
||
| def finalize_buffers(self, squeeze_output=False): | ||
| import zarr | ||
|
|
Member
There was a problem hiding this comment.
How do we ensure that the last buffer is written if the last chunk is not complete ?
Member
Author
There was a problem hiding this comment.
what do you mean? the pipipeline takes care of all chunks
| return self.arrays[0] | ||
|
|
||
|
|
||
| def _split_zarr_store_path(dataset_path): |
Member
There was a problem hiding this comment.
I am not sure that th zarr suffix is a good aproach for this.
Looking for "extensions" would be safer for the analyzer no ?
Member
Author
There was a problem hiding this comment.
I don't understand what you mean here
samuelgarcia
approved these changes
Sep 11, 2026
Member
|
OK for me. |
Co-authored-by: Garcia Samuel <sam.garcia.die@gmail.com>
for more information, see https://pre-commit.ci
…nto gather-to-zarr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues in the direction of support for very long chronic data. This feature prevents loading all spike vector based extension data to memory prior to saving!
GatherToZarrclass to save node pipeline data as it's being computed to zarr datasets.GatherToNpyto be able to specify multiple folders for different filesThese two changes allow to extend the
SortingAnalyzercompute functionality to directly save extension data from node pipelines computations (usually spike-vector based extensions) directly to their final location (numpy files or zarr datasets).This is only enabled when the
SortingAnalyzerhas a folder backend (binary folder or zarr).