Skip to content

v1 grid overrides: NonBinned - #618

Closed
dmitriyrepin wants to merge 22 commits into
TGSAI:v1from
dmitriyrepin:grid_overrides-NonBinned
Closed

dmitriyrepin wants to merge 22 commits into
TGSAI:v1from
dmitriyrepin:grid_overrides-NonBinned

Conversation

@dmitriyrepin

Copy link
Copy Markdown
Contributor

No description provided.

@dmitriyrepin dmitriyrepin changed the title Grid overrides: NonBinned - Proposal Grid overrides: NonBinned - Proposal - over earlier PRs Sep 2, 2025
@tasansal tasansal changed the title Grid overrides: NonBinned - Proposal - over earlier PRs v1 grid overrides: NonBinned Sep 3, 2025
@tasansal tasansal added the v1 label Sep 3, 2025
@BrianMichell

Copy link
Copy Markdown
Collaborator

Resolved merge conflicts.

I did document some potential changes in

  • tests/integration/conftest.py _segy_spec_moc_4d() Some of the contents of the segy header appeared to have changed between target and source branches.
  • tests/integration/test_segy_import_export.py The number of dimensions have changed around (current) line 287

I'll re-run with the pre-commit when I'm at a machine that have the appropriate utilities.

@BrianMichell

Copy link
Copy Markdown
Collaborator

This PR is ready for review again @tasansal

@tasansal

tasansal commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

superseeded by #622

@tasansal tasansal closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants