Repository navigation
Grid overrides: AutoChannelWrap - over v1 - #621
Closed
dmitriyrepin wants to merge 4 commits into
Closed
dmitriyrepin wants to merge 4 commits into
dmitriyrepin wants to merge 4 commits into
Conversation
BrianMichell
reviewed
Sep 3, 2025
BrianMichell
approved these changes
Sep 3, 2025
BrianMichell
left a comment
BrianMichell
left a comment
Collaborator
There was a problem hiding this comment.
Only a function name nit-pick. LGTM.
|
|
||
|
|
||
| def _add_text_binary_headers(dataset: Dataset, segy_file: SegyFile) -> None: | ||
| def _add_text_binary_headers(dataset: Dataset, segy_file: SegyFile, grid_overrides: dict) -> None: |
Collaborator
There was a problem hiding this comment.
Suggested change
| def _add_text_binary_headers(dataset: Dataset, segy_file: SegyFile, grid_overrides: dict) -> None: | |
| def _append_ingestion_data(dataset: Dataset, segy_file: SegyFile, grid_overrides: dict) -> None: |
I don't think this is the best name for this function anymore. My suggested name may not be the most applicable either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grid overrides: AutoChannelWrap on top of the v1 without any other previous changes (i.e., Export to SEG-Y, Coca template).
Since the previous PRs are not yet merged into, this PR should be easier to review