Skip to content

feat: improve bot message when opening channels for cast roles - #35

Open
kmaxii wants to merge 1 commit into
masterfrom
fix/bot-message
Open

feat: improve bot message when opening channels for cast roles#35
kmaxii wants to merge 1 commit into
masterfrom
fix/bot-message

Conversation

@kmaxii

@kmaxii kmaxii commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Documentation
    • Updated quest submission instructions to require raw .wav files.
    • Added AABBCC formatting requirements, up to two takes per line, and five seconds of silence at the beginning and end.
    • Simplified filename guidance and revised the introductory formatting.
    • Removed quest name references from submission messages.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 37e8c599-473e-4c16-9b80-a7b39bc049f2

📥 Commits

Reviewing files that changed from the base of the PR and between 33748b6 and b0140e9.

📒 Files selected for processing (1)
  • src/main/java/me/kmaxi/wynnvp/controller/discordcommands/CreateQuestCommand.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The quest command now generates submission messages with the NPC name only. The instructions require raw .wav files, AABBCC formatting, up to two takes per line, and five seconds of silence at both ends.

Changes

Quest submission message

Layer / File(s) Summary
Update submission message construction
src/main/java/me/kmaxi/wynnvp/controller/discordcommands/CreateQuestCommand.java
The submission-message call no longer passes the quest name. The generated message uses updated heading formatting and audio submission requirements. The multi-script filename instruction was removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b0140

This is a localized bot-message behavior change with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review.

Poem

A rabbit checks each .wav with care,
Two takes per line, silence there.
AABBCC marks the trail,
NPC names now tell the tale.
Hop, hop—the quest note is clear!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the change to the bot message used when creating cast-role channels.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bot-message

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant