Skip to content

Outdated Translations Don't Match the Latest Chinese Doc Info 过时翻译与最新原文资讯不一致 #36

Description

@YuevUwU

Current Impact

Note

This PR was submitted while phira-docs was still using mdbook-i18n-helpers and referencing comprehensive-rust
Repo has been re-generate .po file currently based on commit b7dfc7b with d6652b3

Phira SFX Feature Version Changes:

(Path/Name only)
v0.6.6 and below: ending.mp3
v0.6.7: ending.ogg
v0.6.7+a3f00cc (Unreleased): ending.ogg,ending.wav,ending.mp3
btw, if someone want to know the unreleased version changes, you can read the unofficial changelog

What We'll See

https://teamflos.github.io/phira-docs/respack/index.html

- `ending.ogg`:结算界面背景音乐。

https://teamflos.github.io/phira-docs/en/respack/index.html
Current en/ translation is still staying the old version

phira-docs/po/en.po

Lines 390 to 392 in b7dfc7b

#: src/respack/index.md:22
msgid "`ending.mp3`:结算界面背景音乐。"
msgstr "`ending.mp3`: The background music for the score screen."

Related Code

# Back-date the sources to POT-Creation-Date. The content lives in two
# directories:
rm -r src/
git restore --source "$(git rev-list -n 1 --before "$pot_creation_date" @)" src/

Expected

目前 Phira 是参考 https://github.com/google/comprehensive-rust/blob/main/.github/workflows/build.sh 的实作
啊对如果真是完全抄来的,根据Apache许可证来源诚实标一下谢谢,因为可能它们有做其他副作用但抄一半(它们疑似还有检查msg-id)
希望不要回退到旧 commit,而是像翻译者翻译时那样,建 POT 然后 msgmerge --update (见 USAGE.md),这样就会标成 fuzzy,然后以原文显示
PO 和 POT 文件是面向翻译者的,目前也没有大字叫阅读者去以原文(中文)为准(尽管这样讲感觉翻译没意义)
至于这两个新文件要不要 commit 另提 (一是目前.gitignore过滤掉*.pot,二是若未来同时有两个及以上工作流想要commit,可能竞争条件导致失败或覆盖),还是得先看团队方向

Off-topic 抱怨一下

RPE150 优先把 flick.mp3 等效果音优先映射成原音符种类的声音这点有点反人性(尽管该档案存在于谱面根目录),希望文档中所谓「自定义效果音」能注明更详细一点 😭
(Phira 实作应该是正确的)
https://github.com/TeamFlos/phira/blob/b4032f3813a546f48918112b7eb4e8f82ebaf408/prpr/src/parse/rpe.rs#L348-L370

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions