Skip to content

Add input validation to radix_sort iss #14950 #14967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greemich-bot wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −0
Open

Add input validation to radix_sort iss #14950 #14967

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
720680c
Add input validation to radix_sort iss#14950
greemich-bot Jul 21, 2026
691fd5f
Merge branch 'master' into iss14950
greemich-bot Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sorts/radix_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ def radix_sort(list_of_ints: list[int]) -> list[int]:
Examples:
>>> radix_sort([0, 5, 3, 2, 2])
[0, 2, 2, 3, 5]
>>> radix_sort([2, 4, -2, 1, 3])
Traceback (most recent call last):
...
ValueError: Negative numbers are not supported.

>>> radix_sort(list(range(15))) == sorted(range(15))
True
Expand All @@ -29,6 +33,9 @@ def radix_sort(list_of_ints: list[int]) -> list[int]:
buckets: list[list] = [[] for _ in range(RADIX)]
# split list_of_ints between the buckets
for i in list_of_ints:
# check for negative numbers
if i < 0:
raise ValueError("Negative numbers are not supported.")
tmp = int((i / placement) % RADIX)
buckets[tmp].append(i)
# put each buckets' contents into list_of_ints
Expand Down