use aiosqlite instead of blocking sqlite3 in tickets - #74
Open
arshnah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tickets.py was the only cog using plain sqlite3.connect() inside async handlers instead of aiosqlite like everywhere else. every ticket action (open, close, claim, force close, all the config commands) was blocking the whole event loop for the duration of that db call, so the entire bot would stall while a ticket op was running. switched every call site to aiosqlite, moved the initial table setup + ticket counter fetch into an async cog_load instead of doing sync db work in init.
no behavior change, just makes tickets not freeze everything else while it's doing db stuff.