Repository navigation
Tests: the README kind-summary regex accepts CRLF line endings - #8
Merged
Merged
Conversation
On a Windows checkout with core.autocrlf the README has CRLF line endings, and a multiline `$` matches only before `\n`, so the summary table never matched and the test failed with "Collection was empty". CI runs the tests on Linux, so it only showed on Windows. Claude-Session: https://claude.ai/code/session_019V58BHhd4xcqmxoYHpKdTk
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the README's kind summary matches the rules it listsfails on a Windows checkout withcore.autocrlf=true: the README gets CRLF line endings, a multiline$matches only before\n, so the table rows never match and the test reportsAssert.NotEmpty() Failure: Collection was empty. CI runs the tests on Linux, so it only shows locally on Windows. This PR adds\r?before the$.It was the only failure in the full suite on Windows; with this change all 3,002 tests pass.
https://claude.ai/code/session_019V58BHhd4xcqmxoYHpKdTk