Repository navigation
Extract shared rule logic into AbstractTypeCoverageRule - #98
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
abstract-type-coverage-rule
branch
from
October 7, 2026 11:48
3ac77b7 to
0bc8446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four coverage rules (return, param, property, constant) were ~90 % identical copy-paste: same constructor, same
getNodeType(), sameprocessNode()flow (full-path guard, normalize, measure mode, enabled check, format errors).This extracts the shared flow into
AbstractTypeCoverageRule. Each concrete rule now only declares what differs:ConstantTypeCoverageRuleadditionally overridesshouldSkip()(PHP 8.3+ guard) andisEnabled().Net -74 lines, behavior unchanged.
getRequiredTypeLevel(): floatis natively typed (cast from thefloat|intconfig value) so return type coverage stays over the required threshold;isEnabled()uses> 0, equivalent to the previous=== 0check for the non-negative level values.Public
ERROR_MESSAGEconstants kept as-is, so existing tests are untouched. Tests, ECS, PHPStan and Rector pass.