Skip to content

ci: apply the repo standard (EN-214) - #3

Merged
CK-7vn merged 3 commits into
mainfrom
EN-214-repo-standards
Nov 11, 2026
Merged

CK-7vn merged 3 commits into
mainfrom
EN-214-repo-standards

Conversation

@CK-7vn

@CK-7vn CK-7vn commented Nov 6, 2026

Copy link
Copy Markdown
Member

Description of the change

Part of EN-214: one repo standard across every UnlockEd repo (docs/repo-standard.md in unlocked-core). This repo was made from unlocked-product-template, which gets the same change.

  • Commit check: commits.yml (webiny action, job conventional, on push and pull_request) is replaced by conventional-commits.yml, the shared inline check every UnlockEd repo now runs: pull_request only, every non-merge commit, same 11 types. GitHub's Revert button writes Revert "...", which fails; the check prints the conventional rewording (revert: ...).
  • PR title check: same shared file as the other repos, with the same Revert hint.
  • README: check name is now conventional commits.

Merge order (the ruleset still requires the old check name conventional): this PR shows that check as missing. Once checks are green and it is approved, switch this repo's protect-main ruleset to conventional commits (stage/put in core's docs/repo-standard.md), merge, then ask authors of open PRs to rebase.

  • Related issues: EN-214

Release

  • Changelog type: none (ci).
  • Breaking change?: no.

@CK-7vn
CK-7vn requested a review from a team as a code owner November 6, 2026 19:58
@CK-7vn
CK-7vn requested review from corypride and removed request for a team November 6, 2026 19:58

@corypride corypride left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CK-7vn I checked the workflow files against contracts #9 and provider-platforms #3, the protect-main ruleset, the pins, and the README against #2.

  1. The ruleset still requires conventional. (High) This PR reports conventional commits (conventional-commits.yml:15), so it stays blocked until the ruleset's name is swapped. Swap it when this merges, and only after #2 and its release 0.1.0 PR are in, since both still report conventional.
  2. README.md conflicts with #2. (Medium) #2 rewrites the README, including the commit-types section this PR edits. After rebasing on #2, its README.md:149 still says conventional and should say conventional commits.
  3. Missing git rev-list guard. (Nit) contracts #9 checks the range first (ci.yml:51-52), so a bad range fails instead of passing silently. Worth the same line here.

Will approve once rebased on #2 with the README fixed.

@CK-7vn
CK-7vn requested a review from corypride November 9, 2026 22:58

@corypride corypride left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CK-7vn Re-checked at 4cc48a4. Both of my earlier points are fixed.

  1. The merge with main is clean. The PR now touches only the 5 CI/template files plus a one-line README change at README.md:149 (conventional commits). Nothing from #2 is lost, and .release-please-manifest.json (0.1.0) and the release-please config match main.
  2. The rev-list guard and the edited trigger are in (conventional-commits.yml:7-8, :28-29). Every workflow has a top-level permissions: block.
  3. Nit: pr-title.yml:3 is over 80 columns. Optional.

APPROVE. The ruleset still requires conventional, so I will swap it to conventional commits right before merging and merge straight after.

@CK-7vn
CK-7vn merged commit b5723e4 into main Nov 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants