[CK-7vn]

Pre-Submission PR Checklist

• No debug/console/fmt.Println statements
• Unnecessary development comments removed
• [] All acceptance criteria verified
• Functions according to ticket specifications
• [] Tested manually where applicable
• Branch rebased with latest main
• No business logic exists within the database layer
• DB migrations are backward-compatible and online-safe (single UPDATE, no schema change)
• PR title and every commit are conventional commits

Description of the change

Spell the enrollment status Incomplete: Transferred everywhere. The constant is now EnrollmentIncompleteTransferred, the roster report filter uses Transferred, and the seed data and tests are updated. Migration 00004 renames existing Incomplete: Transfered rows. It supersedes 00003, which had standardized on the misspelling.

• Related issues: EN-244

Release

• Changelog type: fix
• Breaking change?: no , but see below.

Additional context

• The roster filter label changes from Transfered to Transferred. The core frontend PR for EN-244 sends the new label, so the two must deploy together. An old client's Transfered filter would match nothing on the new backend.
• Migration 00004 has a no-op Down, because renamed rows can't be told apart from ones already spelled correctly.
• Tests: two new tests (constant value, roster filter mapping) both failed before the change. go test -race ./... passes, and the migration was run against a scratch Postgres 16 with both spellings.
• Decision against: keeping the misspelling, which is what 00003 did.

[carddev81]

@CK-7vn, nice work on this one, I found a few things before it merges:

1. The old spelling can still get written. The enrollment status PATCH (handleUpdateProgramClassEnrollments) saves whatever status string it's sent. I tried "Incomplete: Transfered" against this branch: it returned 200 and that's what got stored. Any browser still running the old frontend after the deploy can write the misspelled rows again, after 00004 has already run. Core goes to staging on merge and Programs is bumped by hand, so the two can easily run out of sync. Please reject statuses we don't know and add a test row for the old spelling:

   if !slices.Contains(models.AllEnrollmentStatuses, enrollment.EnrollmentStatus) {
       return newBadRequestServiceError(errors.New("unknown enrollment status"), "enrollment status")
   }

2. Checklist. "Tested manually" and "All acceptance criteria verified" are ticked, but your verification notes list the browser check as UNVERIFIED. Please run it: transfer a resident who has an active enrollment, then check that the class outcomes and the roster report's Transferred filter both show it. Then tick it. "Branch rebased" is ticked too, but the branch is still on f9ea1cd, and main has three merges since (#4, #5, #7). Please rebase.

3. What has to happen before EN-244 can close:

   • This PR and core #1295 are both merged.
   • A platform PR moves staging's programs.tag to the new main build. Staging is still on sha-1e177e7, and core goes out on its own as soon as it merges.
   • The browser check above passes on staging.

   The ticket's Repo line still says unlocked-core. Please update it to both repos.

[carddev81]

@CK-7vn, awesome work!!!! Two things before it merges:

1. govulncheck is red because the branch is behind main. The only finding is GO-2026-6859, and main already has the Go 1.26.11 bump (#5). Please merge main in again (or rebase). It merges clean, with no conflicts against #10. That turns the check green.

2. Checklist. "Tested manually" and "All acceptance criteria verified" are still ticked, but the browser check hasn't run. It needs core #1295 too, so do it on staging once both are merged. Untick those two until then.

What has to happen before EN-244 can close:

• This PR and core #1295 are both merged.
• A platform PR moves staging's programs.tag (still sha-1e177e7) to the main build that has this PR. Core goes out on its own as soon as it merges, so do both together.
• On staging: transfer a resident with an active enrollment, then check that the class outcomes and the roster report's Transferred filter both show it.
• The ticket's Repo line still says unlocked-core only. Please add unlocked-programs.

[carddev81]

Hey @CK-7vn, found something odd before it merges:

1. The rebase copied six of main's commits onto the branch. "fix: build with Go 1.26.11", the govulncheck change, both release commits, #10 and #11's first commit are on this branch as new commits with new hashes. They're the same changes as main's, so you didn't change govulncheck, but the PR now lists 25 files and 9 commits instead of 12 files and your 2. If it lands as a merge commit, main gets those six commits twice and the next release's changelog repeats them. A squash would put all nine messages in the commit body. Please reset the branch to main and put your two commits back on top:

git fetch origin
git switch EN-244-transferred-spelling
git reset --hard origin/main
git cherry-pick 24b5dab3 dc3dc846
git push --force-with-lease

I tried it: both apply clean, and the result is the same code as your current head.

Also, core #1295 merged yesterday, so staging's frontend sends Transferred now while staging's Programs (sha-9b31a3f) still only knows Transfered. Until this merges and the tag moves, the roster's Transferred filter on staging matches nothing, so let's get this in soon.

What has to happen before EN-244 can close:

• This PR is merged (core #1295 already is).
• A platform PR moves staging's programs.tag to the main build that has this PR.
• On staging: transfer a resident with an active enrollment, then check that the class outcomes and the roster report's Transferred filter both show it.
• The ticket's Repo line still says unlocked-core only. Please add unlocked-programs.

[carddev81]

@CK-7vn, amazing job!!

What has to happen before EN-244 can close:

• This PR is merged (core #1295 already is).
• A platform PR moves staging's programs.tag to the main build that has this PR. EN-119 needs a tag bump too, so if this merges first, one PR to its build covers both.
• On staging: transfer a resident with an active enrollment, then check that the class outcomes and the roster report's Transferred filter both show it.
• The ticket's Repo line still says unlocked-core only. Please add unlocked-programs.