Repository navigation
fix: release-review findings (stats export queue, JSON Feed leniency, change notes) - #366
Merged
Merged
Conversation
…arse for subscribed feeds, accurate change notes Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…pty JSON feeds parsing Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…used downloads, bound the queue test Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes four findings from the beta.8 release-gate review.
Root causes and changes
<a download>, and a browser saves whatever a download link answers, so the error became the file. Root cause: refusing a request the client cannot handle. Two designs: (a) refuse in the server and prevent a second start in the UI plus make errors not look like files (cannot cover a second tab, a bookmark or another page); (b) the server queues the second request behind the first. Chose (b): the slot is now a one-slot channel, the second request waits and then runs, and it is dropped only when its client goes away. No refusal path remains. The test sends a plain cookie-only GET while one export runs and asserts it waits, then returns the attachment, and that a departed client gets nothing."version":"1"or"1.0"would start failing. Strictness is nowParseOptions.Strict, set only by discovery (adding an address); fetching accepts any JSON object with anitemsarray. Both paths tested.changes/downloads-origin.fixed.mdno longer claims reloads or bookmarks for backups (single-use token).changes/tap-targets-layout-text.fixed.mdnow notes the Gazette description wording.Removes the 429 busy path and the atomic flag; adds a channel slot, one option and tests. docs/design.md updated (Downloads, parse rules).
Checks: gofmt, go vet, go test internal/api internal/fetch internal/discover, changelog check.
🤖 Generated with Claude Code