Skip to content

Widgets: Use array_all() in WP_Widget_Media_Gallery::has_content()#12609

Open
Soean wants to merge 2 commits into
WordPress:trunkfrom
Soean:fix/widget-gallery-has-content-array-all
Open

Widgets: Use array_all() in WP_Widget_Media_Gallery::has_content()#12609
Soean wants to merge 2 commits into
WordPress:trunkfrom
Soean:fix/widget-gallery-has-content-array-all

Conversation

@Soean

@Soean Soean commented Jul 20, 2026

Copy link
Copy Markdown
Member

Description

This PR replaces the manual foreach loop in WP_Widget_Media_Gallery::has_content() with the array_all() function, which expresses the same intent — return true only if every attachment ID resolves to a post of type attachment — without the loop-and-early-return boilerplate.

array_all() was introduced in PHP 8.4 and is available in Core for all supported PHP versions via the polyfill in wp-includes/compat.php (since 6.8.0).

The surrounding conditional is also flattened into an early return, but that is a minor side effect. No functional change.

Trac ticket:


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Soean added 2 commits July 20, 2026 13:04
Flatten the nested conditional into an early return when no IDs are present, and replace the manual foreach loop that verifies every gallery ID resolves to an attachment post with the array_all() function, introduced in PHP 8.4 and available in Core via the polyfill in wp-includes/compat.php since 6.8.0.

This makes the intent of the check more explicit without changing behavior.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props soean.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant